NFS doesn't handle share's failures correctly

[Flavio Percoco]

when running cinder create --display_name <name> 5 when external nfs server is unavailable the volume is stuck in creating instead of moving to error

(snapshot-create for example will be in status error).

Version-Release number of selected component (if applicable):

openstack-cinder-2013.1.2-3.el6ost.noarch
python-cinderclient-1.0.4-1.el6ost.noarch
python-cinder-2013.1.2-3.el6ost.noarch

How reproducible:

100%

Steps to Reproduce:
1. add an nfs server to cinder
2. block connectivity to the server using iptables
3. create volume

Actual results:

volume is stuck in creating status instead of moving to error

Expected results:

we should have consistency and move status to error

Additional info: logs

creating a volume is stuck in creating:

[root@opens-vdsb tmp(keystone_admin)]# cinder list
+--------------------------------------+-----------+--------------+------+-------------+----------+--------------------------------------+
| ID | Status | Display Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+--------------+------+-------------+----------+--------------------------------------+
| 0d1c1913-0e9d-4de4-87d1-2d051b6fcfc8 | available | orion-share3 | 5 | None | false | |
| 6d7ff4c0-86f7-40b6-b59d-99e412bf6bbd | in-use | orion-share | 5 | None | false | 8f107ee9-809f-45c3-b062-520968e53bb5 |
| 7325035d-01c7-4f8b-bb3e-7c2aac40fb1a | creating | orion-share7 | 5 | None | false | |
| b88a6220-e22d-4297-a072-516a146f9474 | creating | orion-share6 | 5 | None | false | |
| e243132e-3f70-4a02-b414-3cc450edc1f0 | creating | orion-share5 | 5 | None | false | |
+--------------------------------------+-----------+--------------+------+-------------+----------+--------------------------------------+

creating snapshot results in error:

[root@opens-vdsb ~(keystone_admin)]# cinder snapshot-create 0d1c1913-0e9d-4de4-87d1-2d051b6fcfc8
+---------------------+--------------------------------------+
| Property | Value |
+---------------------+--------------------------------------+
| created_at | 2013-06-25T13:30:23.477040 |
| display_description | None |
| display_name | None |
| id | fc8862e0-f3cc-4cec-b3c9-931182c6e856 |
| metadata | {} |
| size | 5 |
| status | creating |
| volume_id | 0d1c1913-0e9d-4de4-87d1-2d051b6fcfc8 |
+---------------------+--------------------------------------+
[root@opens-vdsb ~(keystone_admin)]# cinder snapshot-list
+--------------------------------------+--------------------------------------+--------+--------------+------+
| ID | Volume ID | Status | Display Name | Size |
+--------------------------------------+--------------------------------------+--------+--------------+------+
| fc8862e0-f3cc-4cec-b3c9-931182c6e856 | 0d1c1913-0e9d-4de4-87d1-2d051b6fcfc8 | error | None | 5 |
+--------------------------------------+--------------------------------------+--------+--------------+------+

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/92083

[OpenStack Infra (hudson-openstack)]

Change abandoned by Duncan Thomas (<email address hidden>) on branch: master
Review: https://review.openstack.org/92083
Reason: Abandoning change: No update for more than 14 days

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/92083

[Sean McGinnis (sean-mcginnis)]

Automatically unassigning due to inactivity.

[Sean McGinnis (sean-mcginnis)]

Looks like proposed fix was close, but still not present in current code base. Would be good to validate this is still needed and get resolved.

[Eric Harney (eharney)]

If this is an issue, set the "soft" nfs mount option.