Ristretto cannot read GIF properly

[crysman]

The GIF image is displayed incorrectly. Both GIMP or gThumb display it correctly. Sample GIF is attached.

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: ristretto 0.6.3-2
ProcVersionSignature: Ubuntu 3.11.0-20.34-generic 3.11.10.6
Uname: Linux 3.11.0-20-generic x86_64
ApportVersion: 2.12.5-0ubuntu2.2
Architecture: amd64
Date: Sat May 3 00:20:16 2014
ExecutablePath: /usr/bin/ristretto
InstallationDate: Installed on 2013-10-26 (188 days ago)
InstallationMedia: Xubuntu 13.10 "Saucy Salamander" - Release amd64 (20131016)
MarkForUpload: True
SourcePackage: ristretto
UpgradeStatus: No upgrade log present (probably fresh install)

[b3nmore (b3nmore)]

Created attachment 4993
Screenshot of ristretto (not) displaying gif.

ristretto 0.6.3 does only display a few 'lines' of a gif image. Have look at the attached screenshot.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[b3nmore (b3nmore)]

Same in trusty. Upstream report: https://bugzilla.xfce.org/show_bug.cgi?id=9983

However, in the xfce bugzilla are reports concerning other issues, which mention gif images, but don't mention this particular issue. This may mean, that it is a ubuntu specific bug.

[b3nmore (b3nmore)]

Debian has it too: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760464

[Ubuntu QA Website (ubuntuqa)]

This bug has been reported on the Ubuntu Package testing tracker.

A list of all reports related to this bug can be found here:
http://packages.qa.ubuntu.com/qatracker/reports/bugs/1315558

[André Miranda (andreldm)]

I'm testing the latest from git(re0eb867) and tried a couple of gifs found on the web, all are rendered correctly.
Can you check if this bug still happens? If so, please attach the file that causes this.

[b3nmore (b3nmore)]

Have you tried a large enough gif? You can use that one for example: https://bugs.launchpad.net/ubuntu/+source/ristretto/+bug/1315558/+attachment/4103701/+files/IMG_0140.gif

[André Miranda (andreldm)]

This one takes about 3 secs to load, blocking the UI. But is rendered without issues.
Even this animated one works here:
https://s-media-cache-ak0.pinimg.com/originals/c6/df/a2/c6dfa22150790c670c988c5196f6ba0e.jpg
(Rename to .gif)

[b3nmore (b3nmore)]

The animated one works with the 'old' 0.6.3 too. It used to be large files, which got rendered only partially. But maybe that was fixed coincidentally.

As a last test you could convert a really huge jpeg (e.g. 20mpixel) to a gif and try, if ristretto can render it correctly. If so, I would consider this bug as closed.

[André Miranda (andreldm)]

I guess this image is good enough for testing purposes:
http://commons.wikimedia.org/wiki/File:Lexington_original_configuration_orig.gif

Here it takes ~7 seconds to open, but no rendering issues again.

I can see that an improvement would be async loading, I'll file a bug for that.

[André Miranda (andreldm)]

*** Bug 11233 has been marked as a duplicate of this bug. ***

[André Miranda (andreldm)]

Check the image attached on bug 11233, here it's *not* being rendered correctly.
Well, finally we've found an image to reproduce this bug.

[b3nmore (b3nmore)]

(In reply to André Miranda from comment #7)
> Check the image attached on bug 11233, here it's *not* being rendered
> correctly.
> Well, finally we've found an image to reproduce this bug.

Yeah, that one isn't rendered correctly either with 0.6.3. But strangely enough only directly after opening it with ristretto. When I cycle through the images in the same folder, its rendered correctly when I hit it again.

[b3nmore (b3nmore)]

Created attachment 5978
ristretto rendering a gif incompletely and filling in some old data

(In reply to André Miranda from comment #5)
> I guess this image is good enough for testing purposes:
> http://commons.wikimedia.org/wiki/File:Lexington_original_configuration_orig.
> gif
>
> Here it takes ~7 seconds to open, but no rendering issues again.

Well, then something got (partially) fixed in this respect since 0.6.3. Here it renders only the first few lines.

I've attached another screen shot of ristretto after loading the animated one from #3, the huge one from #5 and than the large one from #2. It shows, that parts of the not rendered part is filled with some data of the 1st image. Kind of a mem alloc error?

Hope that helps to pin down the root cause of this bug.

[Sean Davis (bluesabre)]

Upstream reports that this is fixed in ristretto 0.8.2.