extra decimal place on Project overview screen

Bug #1315549 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Verónica Musso

Bug Description

On the Project->Overview screen RAM and Storage both include a single decimal position. I think displaying whole numbers would be cleaner and equally useful.

Revision history for this message
Doug Fish (drfish) wrote :
Revision history for this message
Julie Pichon (jpichon) wrote :

The single decimal does look a bit off. Two is usually more common? Do we lose any accuracy if we remove it all together, or are we changing units as needed so it's not adding that much?

https://github.com/openstack/horizon/blob/041b4ff3f2/horizon/templatetags/sizeformat.py#L37 - it seems we're asking for one decimal position in this call.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Doug Fish (drfish) wrote :

I could really go either way (no decimal or 2). 1 decimal seems unexpected to me.

Revision history for this message
Julie Pichon (jpichon) wrote :

2 decimals may be safer if we're concerned about losing accuracy.

tags: added: low-hanging-fruit
Changed in horizon:
assignee: nobody → Verónica Musso (veronica-a-musso)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/93345

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Matthias Runge (mrunge) wrote :

Hmm, I think 1 decimal is pretty much it. I disagree on the need of change here at all.

Revision history for this message
Liz Blanchard (lblanchard) wrote :

Do we have real world examples of these values? As Julie and Doug mentioned above I think it would be best to model the # of decimals we use based on what would be most accurate of a representation for the user.

Revision history for this message
Tzu-Mainn Chen (tzumainn) wrote :

Well, on my mobile devices it looks like only one decimal place is used when displaying space usage. Same if I look at Settings > Details on F19. I think I now agree with Matthias.

Revision history for this message
Julie Pichon (jpichon) wrote :

The comments about keeping one decimal unit sound reasonable. Maybe we could try not showing the decimal part when it's .0? I don't think removing it altogether is good either, 3.7T and 3T or 4T is pretty different.

Revision history for this message
Verónica Musso (veronica-a-musso) wrote :

I agree with Julie, we could keep one decimal unit and not show the decimal part when it's 0. I uploaded a new patch with this option. Thanks!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/93345
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=84d9f29a28a3c3642a630edca6ecb91bb3f76b21
Submitter: Jenkins
Branch: master

commit 84d9f29a28a3c3642a630edca6ecb91bb3f76b21
Author: Veronica Musso <email address hidden>
Date: Mon May 12 15:08:32 2014 -0300

    Removing decimal place when it's 0

    This patch removes the decimal position when it is 0 for RAM and
    Storage values in Project -> Overview screen.

    Change-Id: I54fb547cc7c3392bf9193cc425ae068a736949b1
    Closes-Bug: #1315549

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.