dont-wait-forever-on-simple-test-failures
Bug #1315518 reported by
Tim Simpson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack DBaaS (Trove) |
Fix Released
|
Low
|
Tim Simpson | ||
Bug Description
If something goes wrong in the task manager when the integration tests are running, there's a small error message followed by the test polling the server 200 times until it gets an error for exceeding the rate limits.This makes a simple error impossible to figure out, and is pointless.
Because events are simulated, we shouldn't be allowing time.sleep to get called when there's nothing to do as most likely its a design over-sight, plus if we do that we can stop the test execution as soon as these errors happen.
| Changed in trove: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| milestone: | none → juno-1 |
| importance: | Medium → Low |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to trove (master) | #1 |
| Changed in trove: | |
| status: | Triaged → Fix Committed |
| Changed in trove: | |
| assignee: | nobody → Tim Simpson (tim-simpson) |
| Changed in trove: | |
| status: | Fix Committed → Fix Released |
| Changed in trove: | |
| milestone: | juno-1 → 2014.2 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit f997879cbe5e819
Author: Tim Simpson <email address hidden>
Date: Fri May 2 15:35:47 2014 -0500
Fail a test if time.sleep called for no reason
If a mild error screws something up in task manager, an entire class
of tests will continue polling using GET requests until they hit their
rate limit, destroying any attempt to parse the test output to see
what is wrong. This pull request fixes that.
Change-Id: I7c00a174dfb797
Closes-Bug: 1315518