Unexpected argument 'message' to Error in image list

Bug #1315456 reported by Steve McLellan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Steve McLellan

Bug Description

In engine/resources/nova_utils.py L90, if nova_client.images.list() fails, the exception handler tries to construct a heat.exception.Error with one named parameter, 'message'. The Error class takes only one argument msg_fmt, and the result is `TypeError: __init__() got an unexpected keyword argument 'message'`, which masks the real error.

Correct call would be to omit the keyword.

Changed in heat:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
Revision history for this message
Steve McLellan (sjmc7) wrote :

Pavel - I have a patch for this already as part of finding it, sorry.

Changed in heat:
assignee: Pavlo Shchelokovskyy (pshchelo) → nobody
Steve McLellan (sjmc7)
Changed in heat:
assignee: nobody → Steve McLellan (sjmc7)
Changed in heat:
status: New → In Progress
Thomas Herve (therve)
Changed in heat:
importance: Undecided → Medium
milestone: none → juno-1
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/91838
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=dc42406b909293cec2c14806628138b05341cf92
Submitter: Jenkins
Branch: master

commit dc42406b909293cec2c14806628138b05341cf92
Author: Steve McLellan <email address hidden>
Date: Tue Jun 3 15:52:23 2014 -0500

    Removed 'message' keyword when raising Error

    The exception handler for listing nova images (now glance images)
    was raising an unexpected argument exception because Error() was
    getting called with a 'message' keyword. Removed the keyword in
    line with elsewhere.

    Change-Id: If928aec0bb807495a00b8447a69c4e3dea43fb3b
    Closes-Bug: 1315456

Changed in heat:
status: In Progress → Fix Committed
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.