number format is not localized

[Doug Fish]

The use of commas, decimal points and spaces in numbers is locale sensitive. For example the number 1,000 might be read as 1000 in the US, but as 1 in FR.

http://en.wikipedia.org/wiki/Decimal_mark#Examples_of_use

Specifically the Create Volume page does not honor the local format. I suspect there may be other places that are wrong as well.

[Julie Pichon (jpichon)]

Django has functionality to help with this that we'll probably want to take advantage of ( https://docs.djangoproject.com/en/1.4/topics/i18n/formatting/ ).

I suspect specific, separate bugs should be filed about this as we find them because many places seem to be handled correctly at the moment, testing with French (e.g. Overview, Instance size column, Image details).

[Julie Pichon (jpichon)]

Also https://docs.djangoproject.com/en/1.4/ref/contrib/humanize/#intcomma

[Doug Fish (drfish)]

It seems that somebody fixed this problem. However, it seems to me that the code was always right. Maybe there was a django fix for this problem? In any case, it's working right now. I'm going to cancel this bug.

[Doug Fish (drfish)]

Not sure if this was always broken, or if we've somehow recreated the exact same symptom, but I see that in master Kilo code, Create Volume does not honor the localized number format.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/173496

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/173496
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0872b4a40334a6df863f88e5aa56b31363aff28e
Submitter: Jenkins
Branch: master

commit 0872b4a40334a6df863f88e5aa56b31363aff28e
Author: Doug Fish <email address hidden>
Date: Tue Apr 14 15:05:41 2015 -0500

    Format numbers in a locale sensitive manner

    Create Volume, Create Snapshot, Extend Volume and
    Flavors and Quota all fail to format numbers in a
    locale sensitive manner. This patch changes the code to
    use the intcomma filter before quota, instead of after. Once
    quota has added text the number can no longer be formatted.

    Change-Id: Id9749d9b25d93185b917708b85471e6f765033e2
    Closes-Bug: 1314801

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/176928

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/176928
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=89d9f46750a7506d6910ae792c14ad47feaf53c3
Submitter: Jenkins
Branch: stable/kilo

commit 89d9f46750a7506d6910ae792c14ad47feaf53c3
Author: Doug Fish <email address hidden>
Date: Tue Apr 14 15:05:41 2015 -0500

    Format numbers in a locale sensitive manner

    Create Volume, Create Snapshot, Extend Volume and
    Flavors and Quota all fail to format numbers in a
    locale sensitive manner. This patch changes the code to
    use the intcomma filter before quota, instead of after. Once
    quota has added text the number can no longer be formatted.

    (Pulled from gate, can't pass checks)

    Change-Id: Id9749d9b25d93185b917708b85471e6f765033e2
    Closes-Bug: 1314801
    (cherry picked from commit 0872b4a40334a6df863f88e5aa56b31363aff28e)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/179289

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/179289
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=aba74d04a530fb6c251c15037da96b7a93b83a7e
Submitter: Jenkins
Branch: master

commit 56d5683c8c49558ae22200bc01ec87ea83144003
Author: Akihiro Motoki <email address hidden>
Date: Thu Apr 23 06:58:49 2015 +0900

    Import translations from Transifex for Juno

    * Import ~100% completed translations
      (translations available for 12 languages)
    * Delete incomplete languages
    * Update language list in openstack_dashboard settings.py

    Change-Id: Ie65227e510d95504ed94fb35f0f7273739759601

commit 89d9f46750a7506d6910ae792c14ad47feaf53c3
Author: Doug Fish <email address hidden>
Date: Tue Apr 14 15:05:41 2015 -0500

    Format numbers in a locale sensitive manner

    Create Volume, Create Snapshot, Extend Volume and
    Flavors and Quota all fail to format numbers in a
    locale sensitive manner. This patch changes the code to
    use the intcomma filter before quota, instead of after. Once
    quota has added text the number can no longer be formatted.

    (Pulled from gate, can't pass checks)

    Change-Id: Id9749d9b25d93185b917708b85471e6f765033e2
    Closes-Bug: 1314801
    (cherry picked from commit 0872b4a40334a6df863f88e5aa56b31363aff28e)

commit a1ac5936211cc134a6fd5246007889a5149a18dd
Author: Akihiro Motoki <email address hidden>
Date: Sat Apr 18 19:53:06 2015 +0900

    update .tx/config to match Kilo Transifex resources

    (Pulled from gate, can't pass checks)

    Change-Id: I167d7787d3096c35a9ad73634e69058306731e44

commit 2e1216136a93a1c2129d9de05fcbbd032fae76e2
Author: OpenStack Proposal Bot <email address hidden>
Date: Thu Apr 23 15:48:09 2015 +0000

    Updated from global requirements

    Change-Id: I5602a6489684db95934130f3ce83c8eb37af2d3d

commit 624a85c7eee4e4fb4f88ccc8bd52caa6c0423e89
Author: lin-hua-cheng <email address hidden>
Date: Wed Apr 22 14:45:26 2015 -0700

    Initialize variable 'networks' before referencing

    Fixes the possible UnboundLocalError on the utility class.

    Change-Id: I52d27f90a583f1216a927147d1bd414c5f866608
    Closes-Bug: #1444421
    (cherry picked from commit 2e4996d2d220df0ae36a863fe694706e6f7aeb40)

commit 5c1604275bfbe621e5e168f8ba1f937d308d6ab8
Author: Janet Yu <email address hidden>
Date: Fri Mar 13 13:50:42 2015 -0700

    Fix addition of plugin panel to panel group

    Revert fix from bug #1329050, which adds a plugin panel to its dashboard's
    class. Adding a plugin panel to a dashboard whose class has its panels defined
    in a tuple will fail because the new plugin cannot be appended to the tuple.
    The code errors out before the panel gets added to the dashboard's panel list.
    However, at this point, the panel has already been registered with the
    dashboard. This causes Dashboard.get_panels() to see the panel in its registry
    but not in its panel groups. Consequently, the panel gets put in the "Other"
    panel group instead of its configured one, as described in bug #1378558.

    By not adding the the plugin panel to its dashboard's class, the panel gets
    a...