ofagent: AttributeError: 'OFANeutronAgent' object has no attribute 'updated_ports'

[YAMAMOTO Takashi]

OFANeutronAgent.__init__() calls setup_rpc(), which spawns a thread to consume RPCs.
self.updated_ports, which is accessed by an RPC handler, port_update(), has not been initialized at this point.

[YAMAMOTO Takashi (yamamoto)]

OVS agent seems to have the same problem.

[YAMAMOTO Takashi (yamamoto)]

here's a log. the line numbers are not same as master because of local patches.

2014-04-30 11:48:01.272 ERROR neutron.openstack.common.rpc.amqp [req-b15e55ef-0038-49c8-b1db-7a6e964c3f25 None None] Exception during message handling
2014-04-30 11:48:01.272 TRACE neutron.openstack.common.rpc.amqp Traceback (most recent call last):
2014-04-30 11:48:01.272 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/neutron/neutron/openstack/common/rpc/amqp.py", line 462, in _process_data
2014-04-30 11:48:01.272 TRACE neutron.openstack.common.rpc.amqp **args)
2014-04-30 11:48:01.272 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/neutron/neutron/openstack/common/rpc/dispatcher.py", line 172, in dispatch
2014-04-30 11:48:01.272 TRACE neutron.openstack.common.rpc.amqp result = getattr(proxyobj, method)(ctxt, **kwargs)
2014-04-30 11:48:01.272 TRACE neutron.openstack.common.rpc.amqp File "/opt/stack/neutron/neutron/plugins/ofagent/agent/ofa_neutron_agent.py", line 365, in port_update
2014-04-30 11:48:01.272 TRACE neutron.openstack.common.rpc.amqp self.updated_ports.add(port['id'])
2014-04-30 11:48:01.272 TRACE neutron.openstack.common.rpc.amqp AttributeError: 'OFANeutronAgent' object has no attribute 'updated_ports'
2014-04-30 11:48:01.272 TRACE neutron.openstack.common.rpc.amqp

[Aaron Rosen (arosen)]

Curious how this is occurs, the attribute looks to be setup correctly in the __init__ https://github.com/openstack/neutron/blob/master/neutron/plugins/ofagent/agent/ofa_neutron_agent.py#L279

[YAMAMOTO Takashi (yamamoto)]

aaron,
the RPC consumer thread is set up before that.
https://github.com/openstack/neutron/blob/master/neutron/plugins/ofagent/agent/ofa_neutron_agent.py#L253

[Eugene Nikanorov (enikanorov)]

https://review.openstack.org/#/c/91355/

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/91355
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=717a0a0ab4436e2904360fe4e34226af7d0e412d
Submitter: Jenkins
Branch: master

commit 717a0a0ab4436e2904360fe4e34226af7d0e412d
Author: Eugene Nikanorov <email address hidden>
Date: Wed Apr 30 16:04:58 2014 +0400

    OVS and OF Agents: Create updated_ports attribute before setup_rpc

    setup_rpc spawns rpc-consuming thread that can access
    self.updated_ports before it is created in the constructor

    Change-Id: Icc447c3bb7099125aae30e2430a6ad98ba00f6f9
    Closes-Bug: #1314472

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/98853

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/98853
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=77d8da1ca45ab97a81d94effd3c4119b65fc4278
Submitter: Jenkins
Branch: stable/icehouse

commit 77d8da1ca45ab97a81d94effd3c4119b65fc4278
Author: Eugene Nikanorov <email address hidden>
Date: Wed Apr 30 16:04:58 2014 +0400

    OVS and OF Agents: Create updated_ports attribute before setup_rpc

    setup_rpc spawns rpc-consuming thread that can access
    self.updated_ports before it is created in the constructor

    Change-Id: Icc447c3bb7099125aae30e2430a6ad98ba00f6f9
    Closes-Bug: #1314472
    (cherry picked from commit 717a0a0ab4436e2904360fe4e34226af7d0e412d)