[engine] Deploy fails silently if name of deploying environment is not unique

[Ekaterina Chernova]

Steps to reproduce:
1) Create environment with name "one"
2) Add application (Telnet as an example) and deploy the environment
3) Create another environment with the same name"one"
4) Send environment to deploy

Actual result:

Environment has status Ready, but actually deploy is not started because of stack with the same name as the environment name already exists
Here is traceback from murano-engine
http://paste.openstack.org/show/77637/

[Steve McLellan (sjmc7)]

The simplest solution to this would be to disallow duplicate environment names. I'd suggest making tenant_id/environment name unique and then this will get fixed as a side effect. Ekaterina - would that be an OK solution?

[Ekaterina Chernova (efedorova)]

Yes, that works.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/97347

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/97347
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=d8dacef34f9afea84b1f5206e4977e9c6e2f2c33
Submitter: Jenkins
Branch: master

commit d8dacef34f9afea84b1f5206e4977e9c6e2f2c33
Author: Steve McLellan <email address hidden>
Date: Mon Jun 2 14:47:09 2014 -0500

    Make environment name unique within a tenant

    Duplicate environment names cause all kinds of problems because of
    naming conventions used. There's no real reason to allow them (heat
    allows duplicate stack names but there was a lot of discussion about
    it, and the reason for having them was nobody wanted to remove them).
    In our case, duplicate environment names cause trouble and there is
    no advantage to them.

    Server will return a 409 Conflict in this instance.

    Change-Id: Ibe694c3dab19d77f6de3aa31844ff3e3cc0d9eb4
    Closes-Bug: 1314106