"free pci" in log message never record

Bug #1314008 reported by Ding Xiao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Ding Xiao

Bug Description

In _report_final_resource_view() method

 if 'pci_devices' in resources:
            LOG.audit(_("Free PCI devices: %s") % resources['pci_devices'])
but in update_available_resource() method

if self.pci_tracker:
            self.pci_tracker.clean_usage(instances, migrations, orphans)
            resources['pci_stats'] = jsonutils.dumps(self.pci_tracker.stats)
        else:
            resources['pci_stats'] = jsonutils.dumps([])

resources has key "pci_stats" not "pci_devices"

https://review.openstack.org/#/c/90671/

Ding Xiao (xiaoding1)
Changed in nova:
assignee: nobody → Ding Xiao (xiaoding1)
Changed in nova:
status: New → In Progress
Ding Xiao (xiaoding1)
description: updated
Andrew Laski (alaski)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/90671
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e71926c013ce254bbd7208a288677d0c2b336343
Submitter: Jenkins
Branch: master

commit e71926c013ce254bbd7208a288677d0c2b336343
Author: xiaoding <email address hidden>
Date: Mon Apr 28 16:27:35 2014 +0800

    Correct pci resources log

    In _report_final_resource_view() method, Nova will never record
    "free pci" in log message because 'pci_devices' is not in dict 'resources'.

    Closes-bug: #1314008

    Change-Id: I90f1e3c624922c39e47f5e1fcccc7e33139d54e7

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.