NSX: router_id_get should not raise an exception

Bug #1313918 reported by Armando Migliaccio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Armando Migliaccio
Icehouse
Fix Released
Medium
Armando Migliaccio

Bug Description

During the migration of networks from the old agent-based model and the new agentless model networks router_id_get should not raise an exception; network's subnets may or may have not been uplinked to a router so it's perfectly acceptable to return None instead.

Tags: vmware
Changed in neutron:
assignee: nobody → Armando Migliaccio (armando-migliaccio)
Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/90824
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5e843850527ede7a56fcc24753f87c1e9e3e8bed
Submitter: Jenkins
Branch: master

commit 5e843850527ede7a56fcc24753f87c1e9e3e8bed
Author: armando-migliaccio <email address hidden>
Date: Mon Apr 28 14:18:06 2014 -0700

    NSX: do not raise on missing router during migration step

    Return None for missing router rather raising NotFound exception;
    this is what the client code was expected to handle in the first
    place.

    Closes-bug: 1313918

    Change-Id: I573770a69d0170b027fc990c29aaa87b1fc8eccc

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/94282

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/94282
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8abb05c1d385d457420752211e44a1425aa68883
Submitter: Jenkins
Branch: stable/icehouse

commit 8abb05c1d385d457420752211e44a1425aa68883
Author: armando-migliaccio <email address hidden>
Date: Mon Apr 28 14:18:06 2014 -0700

    NSX: do not raise on missing router during migration step

    Return None for missing router rather raising NotFound exception;
    this is what the client code was expected to handle in the first
    place.

    Closes-bug: 1313918

    Change-Id: I573770a69d0170b027fc990c29aaa87b1fc8eccc
    (cherry picked from commit 5e843850527ede7a56fcc24753f87c1e9e3e8bed)

tags: added: in-stable-icehouse
Alan Pevec (apevec)
tags: removed: icehouse-backport-potential in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.