Segfault when capslock pressed

[Sergey Anek]

1. Launch terminator
2. Open new tab
3. Doubleclick on tab(title edit)
4. Press CapsLock

AR:
Segfault

Ubuntu 14.04, terminator 0.97.

[wizwiz50 (wizwiz50)]

In gtkentry.c the function gtk_entry_focus_out() isn't called because function _entry_to_label() (editablelabel.py) returns True instead of False. This stop other handlers to process the 'focus-out-event'. It explains why GtkEntry doesn't disconnect 'state-changed' which is triggered by hitting capslock.

[wizwiz50 (wizwiz50)]

See https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget-focus-out-event

[wizwiz50 (wizwiz50)]

This patch ensure the 'focus out' event will be catch by gtkentry (see comment in patch)

[wizwiz50 (wizwiz50)]

Sorry, this is the patch :)

[Bryce Harrington (bryce)]

Confirmed the behavior.

[Arnaud Launay (asl-ubuntuone)]

Confirmed the behavior.

[Bryce Harrington (bryce)]

Confirmed in testing that proposed patch fixes the crash. Fix LGTM.
Pushed up to trunk as revision 1553.

[Ronald Portier (Therp) (rportier1962)]

Problem is not solved completely.

Debian Jessie and terminator 0.97.

Steps to reproduce:

- Open terminator and multiple tabs
- Edit title of at least one tab
- Use Caps Lock in Window

# dmesg
[846857.158820] /usr/bin/termin[14105]: segfault at 14 ip 00007f31e161fdc9 sp 00007ffe3c9c9280 error 4 in libgtk-x11-2.0.so.0.2400.25[7f31e155a000+440000]

[Stephen Boddy (stephen-j-boddy)]

@Ronald: You can't use a release older that the release that fixed a bug, then claim the problem isn't solved! You have to upgrade to the newer version. I'd recommend you test the new gtk3 version 1.91 and see if the issue still exists. Then, if it does, *raise a new bug*. Please don't resurrect a bug that was last touched ~18 months ago. The gtk3 libraries are much less susceptible to segfault'ing, and doesn't exhibit this behaviour even without having the patch attached to this bug.