Consider deprecating Granite.Popover in favor of Gtk.Popover
Bug #1313585 reported by
Sergey "Shnatsel" Davidoff
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Granite |
Fix Released
|
Low
|
Corentin Noël | ||
Bug Description
Now that there's a PopOver widget in upstream GTK, we should consider deprecating our implementation which has a number of issues (see bug #1094015, bug #1094012, bug #1116900, bug #1102456, bug #1217324, etc).
Related branches
lp:~tintou/granite/deprecation
- Victor Martinez (community): Approve
- Cody Garver (community): Needs Information
- Robert Roth (community): Approve
-
Diff: 32 lines (+2/-2)2 files modifiedlib/Widgets/PopOver.vala (+1/-2)
lib/Widgets/WrapLabel.vala (+1/-0)
| Changed in granite: | |
| milestone: | none → isis-beta1 |
| milestone: | isis-beta1 → 0.3.1 |
Revision history for this message
| Danielle Foré (danrabbit) wrote | #1 |
| Changed in granite: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
Revision history for this message
| Danielle Foré (danrabbit) wrote | #2 |
| Changed in granite: | |
| assignee: | nobody → Corentin Noël (tintou) |
| milestone: | 0.3.1 → freya-rc1 |
| status: | Confirmed → Fix Committed |
| Changed in granite: | |
| status: | Fix Committed → In Progress |
| Changed in granite: | |
| status: | In Progress → Fix Committed |
| Changed in granite: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The big blocker (IIRC) here is that Slingshot is using Granite.Popover. In order to change it to a gtk.popover, we'd have to make it an actual part of Wingpanel (either hardcoded or a plugin) because gtk.popover needs a parent window.