Wrong logic in clean method for SetInstanceDetailsAction

[Liyingjun]

This <elif source_type == 'volume_image_id'> will never be called: https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#n265 , because <if source_type in ('image_id', 'volume_image_id')> is called before the code, https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#n186

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/90629

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/90629
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a896dd7300012fffd7c0d795298e471c819421df
Submitter: Jenkins
Branch: master

commit a896dd7300012fffd7c0d795298e471c819421df
Author: liyingjun <email address hidden>
Date: Thu Apr 24 07:45:13 2014 +0800

    Fixes wrong logic for clean method in SetInstanceDetailsAction

    If the 'Instance Boot Source' is 'Boot from image (creates a new
    volume)', the 'Device Size' and 'Device Name' fields will never be
    checked.

    Change-Id: Ic34de83a46716f6489d017275f9b64ce0c951858
    Fixes-bug: 1313473