OpenStack Dashboard (Horizon)

Memory reported improperly in admin dashboard

Bug #1313009 reported by Kevin Stevens
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Kevin Stevens
OpenStack Dashboard (Horizon) 2014.2 "juno"
Icehouse
Fix Released
Undecided
Unassigned
OpenStack Dashboard (Horizon) 2014.1.4

Bug Description

The admin dashboard works with memory totals and usages as integers. This means that, for example, if you have a total of 1.95 TB of memory in your hypervisors you'll see it reported as 1 TB.

Revision history for this message
Julie Pichon (jpichon) wrote :

Thanks for the bug report. It looks like we use the mbformat filter on the memory usage, we probably want to use the mb_float_format filter instead.

https://github.com/openstack/horizon/blob/041b4ff3f2/openstack_dashboard/dashboards/admin/hypervisors/templates/hypervisors/index.html#L23

https://github.com/openstack/horizon/blob/041b4ff3f2/horizon/templatetags/sizeformat.py

tags: added: low-hanging-fruit
Changed in horizon:
status: New → Triaged
importance: Undecided → Low
Kevin Stevens (kstev)
Changed in horizon:
assignee: nobody → Kevin Stevens (kstev)
status: Triaged → In Progress
Revision history for this message
Julie Pichon (jpichon) wrote :

Review at https://review.openstack.org/#/c/89738/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/89738
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a309df5a16efd35d207cb78aaa59f2aebe8a3d2c
Submitter: Jenkins
Branch: master

commit a309df5a16efd35d207cb78aaa59f2aebe8a3d2c
Author: kstev <email address hidden>
Date: Tue Apr 22 22:12:48 2014 -0500

    Use floats instead of integer in memory calculation of admin dashboard

    In the case that hypervisors have large amounts of memory, you'll find that
    the dashboard reports improper memory usage when in the TB and PB range.
    For example, 1.95 TB as an integer equals 1 so we convert to float instead.

    Fixes bug: 1313009

    Change-Id: Ie107986fa3ed9aad5c68c34353cdfc5943788069

Changed in horizon:
status: In Progress → Fix Committed
Julie Pichon (jpichon)
Changed in horizon:
importance: Low → Medium
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/135640

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/icehouse)

Reviewed: https://review.openstack.org/135640
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e00979e2827b7d680a658952907b9c3cc658b29f
Submitter: Jenkins
Branch: stable/icehouse

commit e00979e2827b7d680a658952907b9c3cc658b29f
Author: kstev <email address hidden>
Date: Tue Apr 22 22:12:48 2014 -0500

    Use floats instead of integer in memory calculation of admin dashboard

    In the case that hypervisors have large amounts of memory, you'll find that
    the dashboard reports improper memory usage when in the TB and PB range.
    For example, 1.95 TB as an integer equals 1 so we convert to float instead.

    Closes-Bug: #1313009

    Change-Id: Ie107986fa3ed9aad5c68c34353cdfc5943788069
    (cherry picked from commit a309df5a16efd35d207cb78aaa59f2aebe8a3d2c)

tags: added: in-stable-icehouse
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.