Item Status - Alternate View - Holds/Transit tab: Transit and Hold information does not refresh

Bug #1312837 reported by Michele Morgan
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

With multiple items listed on the Item Status list, information on the Alternate View -> Holds/Transit tab does not always refresh when viewing a different item. Some information from an Available item will persists when subsequently viewing an In Transit item, and vice versa.

The attached .doc file shows an example and screenshots illustrating the information that is not refreshed.

Related bugs are:

Item Status Alternate View Residual Times Data
https://bugs.launchpad.net/evergreen/+bug/1312703

and

Item Details->Alt View->Hold/Transit tab is showing two transit lists rather than a hold list and a transit list
https://bugs.launchpad.net/evergreen/+bug/949101

Revision history for this message
Michele Morgan (mmorgan) wrote :

Attaching the .doc

Revision history for this message
Erica Rohlfs (erohlfs) wrote :

Confirmed on version 2.6.0. The Item Status screen lacks a way for the user to select a Refresh or Reload Page, as well (unless I'm completely over looking it).

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

This is still an issue in 2.10.6 also. This issue also happens between tabs. I opened an item in items status alternative view and looked at the Holds/Transit info, that item was in transit to fill a hold.

I then opened a new tab and looked at a new item that was on the holdshelf. That item showed the same transit info in the data list as the first item.

Josh

Revision history for this message
Kathy Lussier (klussier) wrote :

Has anyone checked to see if this is an issue in the web client?

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I found a fix for this. (I know it is tacky to work on XUL on web client day... but this was bugging me.)

Also, my statement about it happening between tabs is wrong, I just lost track of where I had loaded some records.

I just noticed that in alternate_copy_summary.js, where there was hold and transit data, a hold_list.clear() and transit_list.clear() function is called, but when there is no hold or transit data, the list isn't touched. Adding the clear functions to the case where there is no hold or transit data clears out the old data from the previous view.

I also added a call to set the hold_patron_name label value to blank. That clears out the patron name when it is already set. That had the side effect of adding an extra space between the transit label and the list though. I need to find a better way to clear that.

Branch on the way.
Josh

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Working Branch at
user/stompro/lp1657861_alt_item_status_hold_transit

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1657861_alt_item_status_hold_transit

I needed to add two strings to staff_client/server/locale/en_US/circ.properties. Please let me know if there is something else that needs to be done when adding translatable strings.

Josh

tags: added: pullrequest staffclient
Changed in evergreen:
assignee: nobody → Jennifer Pringle (jpringle-u)
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

I have tested this code and consent to signing off on it with my email address, [<email address hidden>], and name [Jennifer Pringle].

Changed in evergreen:
assignee: Jennifer Pringle (jpringle-u) → nobody
tags: added: signed signedoff
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

I briefly tested this issue a 2.12 web client (without the fix) and the sandbox with the fix and I didn't see this issue so it may not have ever been an issue in the web client.

Kathy Lussier (klussier)
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
Revision history for this message
Kathy Lussier (klussier) wrote :

Thank you Josh and Jennifer!

Since there are two new strings in this fix, I'll leave it to the release 2.11 maintainer to decide if the fix should be backported to 2.11.

I've merged the code to master and release 2.12.

Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
status: Confirmed → Fix Committed
milestone: none → 2.12.4
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.