open-ils.circ.hold.change_title(.specific_holds) APIs cancel previously captured holds at other locations, confusing staff and patrons
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
2.11 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Evergreen: All currently supported
OpenSRF: *
PgSQL: *
OS: *
Both of these APIs call search_
my $holds = $e->search_
[
{
},
{
}
],
{ substream => 1 }
);
The worst issue with these calls is that they don't check for capture_time => undef, meaning that items currently waiting for pickup can suddenly "vanish" from the holds shelf. This is an easy fix and fixes an infuriating issue.
More subtly, however, is that transits are also canceled as part of this process. This is nightmarish if your courier system isn't highly accurate. Items show up at their destinations already "available" if they show up at all. This one I don't know how to manage since ahr doesn't "know" that copies are in transit.
Branch incoming to at least take care of the capture_time check, I'm less sure how best to not cancel transits in-flight.
tags: | added: holds |
summary: |
- open-ils.circ.hold.change_title(.specific_holds) APIs casuse havoc when + open-ils.circ.hold.change_title(.specific_holds) APIs cause havoc when used |
Changed in evergreen: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
assignee: | nobody → Jeff Godin (jgodin) |
milestone: | none → 2.next |
milestone: | 2.next → 2.5.6 |
summary: |
- open-ils.circ.hold.change_title(.specific_holds) APIs cause havoc when - used + open-ils.circ.hold.change_title(.specific_holds) APIs cancel previously + captured holds at other locations, confusing staff and patrons |
Changed in evergreen: | |
milestone: | 2.5.7 → 2.5.8 |
tags: | added: pullrequest |
Changed in evergreen: | |
assignee: | Jeff Godin (jgodin) → nobody |
Changed in evergreen: | |
assignee: | nobody → Kathy Lussier (klussier) |
Changed in evergreen: | |
milestone: | 2.5.8 → 2.next |
Changed in evergreen: | |
assignee: | Kathy Lussier (klussier) → nobody |
Changed in evergreen: | |
assignee: | nobody → Kathy Lussier (klussier) |
tags: | added: signedoff |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Currently untested, yet trivially simple: git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/collab/ jboyer/ LP1312824- change_ title_capture_ time
http://