set_console_mode ovewritting the last_error field

[Lucas Alvares Gomes]

When the driver does not support console and you try to enable/disable the console the error returned to the user (in a sync way) is correct but it's overwirtting the node.last_error field with that message too[1]. It shouldn't, the last_error field is meant to be used by async tasks running in the background, for sync tasks retuning the error to the user is enough.

[1] https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L854-L858

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/90376

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/90376
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=6e28689b2e8e44b977057d8a98a5f68ad7e5f96e
Submitter: Jenkins
Branch: master

commit 6e28689b2e8e44b977057d8a98a5f68ad7e5f96e
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Apr 25 14:54:51 2014 +0100

    Return error immediately if set_console_mode is not supported

    Currently, if set_console_mode is not supported by the driver, the
    error is recorded on the node.last_error field, but the user is not
    otherwise notified. This field should only be used for asynchronous
    feedback; the determination as to whether set_console_mode is supported is
    synchronous. Therefor, it should return an error to the user immediately
    and not alter node.last_error.

    Closes-bug: #1312757
    Change-Id: I015047175161809258ec08a02b2490613cf94466