Passing the 'node' parameter to the driver interfaces

[Lucas Alvares Gomes]

Pretty much all methods of the driver interfaces[1] gets two parameters: task and node. This is due history reasons, but right now node is redundant and should be removed from the interface, the task object already contains the node so we only need to pass 'task' for those methods.

[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/90363

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/91062

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/91104

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/90363
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=73b02ec9b1afe2b5cb1d123b067ed60e582fdffc
Submitter: Jenkins
Branch: master

commit 73b02ec9b1afe2b5cb1d123b067ed60e582fdffc
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Apr 25 11:04:06 2014 +0100

    Remove 'node' parameter from the VendorPassthru interface

    The node is redundant since the node object is an attribute of the
    task object.

    Partial-Bug: #1312632
    Change-Id: I14f921023d020eb5a0b8caf1b3c5fa6f248b9ff6

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/91062
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ec6a73b4fcc7f5fdad3cc0ab2a1eff26b2253d52
Submitter: Jenkins
Branch: master

commit ec6a73b4fcc7f5fdad3cc0ab2a1eff26b2253d52
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Apr 29 16:03:56 2014 +0100

    Remove 'node' parameter from the Deploy interface

    The node parameter is redundant since the node object is an attribute
    of the task object.

    In the PXE driver, the helper functions _create_token_file,
    _remove_internal_attrs, _update_neutron and _create_pxe_config were also
    updated removing the 'node' parameter from the function definition.

    Partial-Bug: #1312632
    Change-Id: I82b3078c00cdf6e417c3f379bf03f1c5cae533d7

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/95670

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/91093
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=2539b709d2856c7fd954af5157dbacd7f280ca67
Submitter: Jenkins
Branch: master

commit 2539b709d2856c7fd954af5157dbacd7f280ca67
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Apr 29 17:30:44 2014 +0100

    Remove 'node' parameter from the Power interface

    The node parameter is redundant since the node object is an attribute
    of the task object.

    Partial-Bug: #1312632
    Change-Id: I4baa8526768a250e0cf047f56322039157772376

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/95670
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=377915b2369232f97ccaa313948f7d9f212f3873
Submitter: Jenkins
Branch: master

commit 377915b2369232f97ccaa313948f7d9f212f3873
Author: Yuiko Takada <email address hidden>
Date: Tue May 27 16:39:42 2014 +0000

    Remove "node" parameter from methods handling power state in docs

    This patch fixes the doc about methods handling power state
    to remove the parameter "node".
    * validate
    * get_power_state
    * set_power_state
    * reboot

    Change-Id: I5c0425e1502f304b62566aa1e63823214888ef66
    Partial-Bug: #1312632

[aeva black (tenbrae)]

Updating priority. As per https://wiki.openstack.org/wiki/Bugs#Importance, this does not meet the criteria for a "high" priority bug, even if we want to fix it soon.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/91419
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=2b2022c331d78b5ca1df6d06a58d2229af3036b7
Submitter: Jenkins
Branch: master

commit 2b2022c331d78b5ca1df6d06a58d2229af3036b7
Author: Chris Behrens <email address hidden>
Date: Mon Apr 28 12:04:22 2014 -0700

    TaskManager: Only support single node locking

    The multi-node locking is not used and there's no plan to use it.
    Removing it allows us to clean up a lot of code.

    The TaskManager tests are refactored to not use the DB.

    Removed 'node' from get_node_mac_addresses() in driver/utils as it's
    no longer needed.

    Partial-Bug: 1312632

    Change-Id: Ie3577ba150df6c84fc34a4b08775e5011f8925cb

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/91097
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=4da3ec8b8ae75e8ffc7582c4b0c37c1f9c14dd75
Submitter: Jenkins
Branch: master

commit 4da3ec8b8ae75e8ffc7582c4b0c37c1f9c14dd75
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Apr 29 17:47:30 2014 +0100

    Remove 'node' parameter from the Console and Rescue interfaces

    The node parameter is redundant since the node object is an attribute
    of the task object.

    Partial-Bug: #1312632
    Change-Id: Ic7bf898b7d881e36188511d75837e450f29f066c

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/91104
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=216969427b964d91079c0f781b8579a6aaa8290c
Submitter: Jenkins
Branch: master

commit 216969427b964d91079c0f781b8579a6aaa8290c
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Apr 29 18:12:15 2014 +0100

    Remove 'node' parameter from the validate() methods

    The node parameter is redundant since the node object is an attribute
    of the task object.

    Closes-Bug: #1312632
    Change-Id: Ia4193ea561a31e54754049d9964c6c9021474caf