Downgrade doesn't work in 4eca4a84f08a_remove_ml2_cisco_cred_db migration

[Ann Taraday]

In downgrade for 4eca4a84f08a_remove_ml2_cisco_cred_db there is a mistake in usage SQLAlchemy String type. Used sa.string instead of sa.String

akamyshnikova@akamyshnikova:/opt/stack/neutron$ neutron-db-manage --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini downgrade -10
INFO [alembic.migration] Context impl MySQLImpl.
INFO [alembic.migration] Will assume non-transactional DDL.
INFO [alembic.migration] Running downgrade 1dde83e0359e -> 26a933acf533, add_index_psql_cisco
INFO [alembic.migration] Running downgrade 26a933acf533 -> 30231c78a878, add_index_psql_packetfilter
INFO [alembic.migration] Running downgrade 30231c78a878 -> 168ce7333432, add_index_psql_metering
INFO [alembic.migration] Running downgrade 168ce7333432 -> 6be312499f9, add_index_psql_fwaas
INFO [alembic.migration] Running downgrade 6be312499f9 -> d06e871c0d5, set_not_null_vlan_id_cisco
INFO [alembic.migration] Running downgrade d06e871c0d5 -> 4eca4a84f08a, set_admin_state_up_not_null_ml2
INFO [alembic.migration] Running downgrade 4eca4a84f08a -> 33c3db036fe4, Remove ML2 Cisco Credentials DB
Traceback (most recent call last):
  File "/usr/local/bin/neutron-db-manage", line 10, in <module>
    sys.exit(main())
  File "/opt/stack/neutron/neutron/db/migration/cli.py", line 167, in main
    CONF.command.func(config, CONF.command.name)
  File "/opt/stack/neutron/neutron/db/migration/cli.py", line 81, in do_upgrade_downgrade
    do_alembic_command(config, cmd, revision, sql=CONF.command.sql)
  File "/opt/stack/neutron/neutron/db/migration/cli.py", line 59, in do_alembic_command
    getattr(alembic_command, cmd)(config, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/alembic/command.py", line 150, in downgrade
    script.run_env()
  File "/usr/local/lib/python2.7/dist-packages/alembic/script.py", line 199, in run_env
    util.load_python_file(self.dir, 'env.py')
  File "/usr/local/lib/python2.7/dist-packages/alembic/util.py", line 205, in load_python_file
    module = load_module_py(module_id, path)
  File "/usr/local/lib/python2.7/dist-packages/alembic/compat.py", line 58, in load_module_py
    mod = imp.load_source(module_id, path, fp)
  File "/opt/stack/neutron/neutron/db/migration/alembic_migrations/env.py", line 103, in <module>
    run_migrations_online()
  File "/opt/stack/neutron/neutron/db/migration/alembic_migrations/env.py", line 87, in run_migrations_online
    options=build_options())
  File "<string>", line 7, in run_migrations
  File "/usr/local/lib/python2.7/dist-packages/alembic/environment.py", line 681, in run_migrations
    self.get_context().run_migrations(**kw)
  File "/usr/local/lib/python2.7/dist-packages/alembic/migration.py", line 225, in run_migrations
    change(**kw)
  File "/opt/stack/neutron/neutron/db/migration/alembic_migrations/versions/4eca4a84f08a_remove_ml2_cisco_cred_db.py", line 53, in downgrade
    sa.Column('credential_id', sa.string(length=255), nullable=True),
AttributeError: 'module' object has no attribute 'string'

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/90061

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/90061
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e575fde4cbe9b23cfc103e2de2f4052dd5874b02
Submitter: Jenkins
Branch: master

commit e575fde4cbe9b23cfc103e2de2f4052dd5874b02
Author: Ann Kamyshnikova <email address hidden>
Date: Thu Apr 24 15:34:45 2014 +0400

    Fix incorrect usage of sa.String() type

    In downgrade of 4eca4a84f08a_remove_ml2_cisco_cred_db migartion
    there is a mistake in usage SQLAlchemy String type.
    Used sa.string() instead of sa.String()

    Change-Id: I521dd63ca2b48e902ca2cb17c45a3fe996b060e7
    Closes-bug: #1312124