textbox attachment chooser tabs cause the config form to shrink

Bug #1311876 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
1.9
Fix Released
High
Robert Lyon

Bug Description

Regression, affects v1.9 / master

To test:
1) upload some files in administration -> configure site -> files
2) upload some files in user's content -> files
3) create portfolio page and add a textbox

The config form loads fine and is wide enough, but when one selects the 'site files' tab the config form shrinks and cuts off the right hand side of the artefact chooser area.

Tags: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3281

Revision history for this message
Robert Lyon (robertl-9) wrote :

Looks to affect FF but not Chrome

Changed in mahara:
status: Confirmed → In Progress
Aaron Wells (u-aaronw)
tags: added: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3281
Committed: http://gitorious.org/mahara/mahara/commit/8b18a7b1dff7c4c2c0b096a12347c61eb33211b4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8b18a7b1dff7c4c2c0b096a12347c61eb33211b4
Author: Robert Lyon <email address hidden>
Date: Thu Apr 24 10:10:32 2014 +1200

Setting correct width when changing artefact chooser tabs (Bug #1311876)

Currently the js wants to get the width of the <TD> element but it is
returning 0, getting the width from the <table> element returns
correct value.

Change-Id: I093cb56c0654ca2a90f521f6089b08cd7c227367
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/3356

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3356
Committed: http://gitorious.org/mahara/mahara/commit/73da7f222299209303f38da8d5c807d4974af2a4
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 73da7f222299209303f38da8d5c807d4974af2a4
Author: Robert Lyon <email address hidden>
Date: Thu Apr 24 10:10:32 2014 +1200

Setting correct width when changing artefact chooser tabs (Bug #1311876)

Currently the js wants to get the width of the <TD> element but it is
returning 0, getting the width from the <table> element returns
correct value.

Change-Id: I093cb56c0654ca2a90f521f6089b08cd7c227367
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.