neutron

OpenDaylight ML2 Mechanism Driver does not handle authentication errors

Bug #1311758 reported by Dave Tucker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Dave Tucker
neutron 2014.2 "juno"
Icehouse
Fix Released
Medium
Cédric OLLIVIER
neutron 2014.1.3

Bug Description

This behaviour was noticed when troubleshooting a misconfiguration.
Authentication with ODL was failing and the exception was being ignored.

In the "sync_resources" method of the ODL Mechanism Driver, HTTPError exceptions with a status code of 404 are handled but the exception is not re-raised if the status code is not 404.
It is preferable to re-raise this exception.

In addition it would be helpful if the "obtain_auth_cookies" should throw a more specific exception than HTTPError when authentication with the ODL controller fails.

Revision history for this message
Dave Tucker (davetucker) wrote :

Patch incoming....

Changed in neutron:
assignee: nobody → Dave Tucker (davetucker)
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/89886
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7db44edd3c5ad4aea508c3cc74a8b0b8d785c26b
Submitter: Jenkins
Branch: master

commit 7db44edd3c5ad4aea508c3cc74a8b0b8d785c26b
Author: Dave Tucker <email address hidden>
Date: Wed Apr 23 17:01:38 2014 +0100

    Improve ODL ML2 Exception Handling

    Raise a MechanismDriverError when authentication with ODL fails.
    Re-raise HTTPError in "sync_resources" for exceptions whose status code is not 404.

    Closes-Bug: #1311758
    Change-Id: I99d2c4f270007c369024525ba4e6188d232a0b13

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-1
status: Fix Committed → Fix Released
Cédric OLLIVIER (m.col)
tags: added: icehouse-backport-potential opendaylight
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/122098

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/122098
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6de6d612631e33c0a5cfe01b1729950b15fbd1bd
Submitter: Jenkins
Branch: stable/icehouse

commit 6de6d612631e33c0a5cfe01b1729950b15fbd1bd
Author: Dave Tucker <email address hidden>
Date: Wed Apr 23 17:01:38 2014 +0100

    Improve ODL ML2 Exception Handling

    Raise a MechanismDriverError when authentication with ODL fails.
    Re-raise HTTPError in "sync_resources" for exceptions whose status code is not 404.

    Closes-Bug: #1311758
    Change-Id: I99d2c4f270007c369024525ba4e6188d232a0b13
    (cherry picked from commit 7db44edd3c5ad4aea508c3cc74a8b0b8d785c26b)

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.