volume size as NUMBER leads to inconsistency

Bug #1311707 reported by Pavlo Shchelokovskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Pavlo Shchelokovskyy

Bug Description

the type of the SIZE property should rather be INTEGER and not NUMBER. Currently it is possible to provide a rational value for the volume size, but cinder will silently round it down, which leads to inconsistency between stack properties known to heat (via self.properties and stack.t, that still hold rational number) and actual volume size reported by cinder.

Changed in heat:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
summary: - fix size property shema in volume resources
+ volume size as NUMBER leads to inconsistency
description: updated
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89880

Changed in heat:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/89880
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=aa5bf56c130c86e964384fe54f849da630d5740a
Submitter: Jenkins
Branch: master

commit aa5bf56c130c86e964384fe54f849da630d5740a
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Apr 23 10:48:57 2014 +0000

    Change volume size property type to integer

    Before it was possible to provide a rational number for SIZE, but cinder
    would silently round it down, which leads to inconsistency between
    stored resource state and actual cinder volume.

    Closes-Bug: #1311707
    Change-Id: I97b110f9797e2046bd5d2ae7da227b8dfc19059a

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.