clonetemplate lock can be left stale

[John A Meinel]

I was testing out some of the issues with Local and using both precise and trusty. While doing so I bootstrapped and destroy-environment a few times.

Eventually I ended up with:
2014-04-23 13:36:11 INFO juju.container.lxc clonetemplate.go:78 wait for fslock on juju-trusty-template
2014-04-23 13:36:11 INFO juju.utils.fslock fslock.go:146 attempted lock failed "juju-trusty-template", ensure clone exists, currently held: ensure clone exists

And the dir /var/lib/juju/locks/juju-trusty-template was indeed still 'held' by no process.

My guess is that destroy-environment shuts things down, but they don't clean up the lock that was taken.

[Curtis Hovey (sinzui)]

Stale locks are the cause of "service stuck in pending" seen in landscape and maas testing. See the duplicate bugs for more details.