cinder causes tgtd to crash when default-driver is not configured

[Dirk Mueller]

tgtd is crashing reproducibly on the cinder volumes host when doing this:

# cinder create 1 -> <volume-id-1>
# nova volume-attach <running-vm> <volume-id-1> /dev/vdb
# nova volume-detach <running-vm> <volume-id-1>
# cinder snapshot-create <volume-id-1>
# cinder create --snapshot-id <id-of-just-created-snapshot> 1 -> <volume-id-2>
# cinder snapshot-delete <id-of-just-created-snapshot>
# cinder delete <volume-id-1>
# nova volume-attach <running-vm> <volume-id-2> /dev/vdb

and /etc/tgt/targets.conf does not specify the default-driver for lld. Ideally all Cinder configured volumes would specify the lld driver, avoiding this configuration issue.

[Duncan Thomas (duncan-thomas)]

I don't seem to be able to reproduce this on devstack, though I can reproduce it. Any idea why it doesn't happen on devstack? (i.e. can we improve our testing to catch similar issues)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/88248
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=872b7ca0fc5ce4911fdaadee464d46be5a38058d
Submitter: Jenkins
Branch: master

commit 872b7ca0fc5ce4911fdaadee464d46be5a38058d
Author: Dirk Mueller <email address hidden>
Date: Thu Apr 17 13:49:05 2014 +0200

    Specify lld in tgt config backends

    Otherwise when running tgt-admin --delete, it might forget
    to invoke tgtadmn with "--lld iscsi" in order to delete the low-level
    iscsi exports, which can cause crashes or hangs later on.

    Closes-Bug: #1311640
    Change-Id: I436c67c30565089236e987d84ac2609eedd2d2c7

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/94595

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/94596

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/94595
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cab4ef6635cf6cd5c28c02db6099555d22d1bc22
Submitter: Jenkins
Branch: stable/icehouse

commit cab4ef6635cf6cd5c28c02db6099555d22d1bc22
Author: Dirk Mueller <email address hidden>
Date: Thu Apr 17 13:49:05 2014 +0200

    Specify lld in tgt config backends

    Otherwise when running tgt-admin --delete, it might forget
    to invoke tgtadmn with "--lld iscsi" in order to delete the low-level
    iscsi exports, which can cause crashes or hangs later on.

    Closes-Bug: #1311640
    Change-Id: I436c67c30565089236e987d84ac2609eedd2d2c7
    (cherry picked from commit 872b7ca0fc5ce4911fdaadee464d46be5a38058d)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alan Pevec (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/94596
Reason: Final Havana release 2012.3.4 has been cut and stable/havana is going to be removed in a week.