no close button on developer tools window

[Max Linke]

the new dev-tools should also have a close button. This is a really nice thing by the way when was this added?

[RJ Skerry-Ryan (rryan)]

Do you mean a button in the actual dialog or the standard OS close button?

Thanks :) I added this a few weeks ago. I've been wanting it forever.

[Max Linke (max-linke)]

yup the standard OS close button

On Tue, 2014-04-22 at 22:17 +0000, RJ Ryan wrote:
> Do you mean a button in the actual dialog or the standard OS close
> button?
>
> Thanks :) I added this a few weeks ago. I've been wanting it forever.
>

[RJ Skerry-Ryan (rryan)]

I have a standard OS close button on OS X though...

[Max Linke (max-linke)]

hm I have it also on windows. I'll test it a bit more

[kNottien (kentarveolsen)]

ESC button works in linux, why have a button?

[Max Linke (max-linke)]

OK this seems to be an issue with GTK3. They assume that a Dialog shouldn't have a close button[1][2], The solution is to convert the window type from a Dialog to a Window.

https://github.com/mixxxdj/mixxx/pull/295

[1] https://github.com/nvbn/everpad/issues/88

[2] https://stackoverflow.com/questions/8691025/qt-qdialog-and-gnome-3-how-to-display-the-close-button-title-bar-and-make-it-mo

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7445