documentation does not specify that [auth] drivers only work with v3 API

Bug #1311324 reported by Matt Fischer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Kevin Kirkpatrick

Bug Description

The documentation on auth plugins (http://docs.openstack.org/developer/keystone/configuration.html#how-to-implement-an-authentication-plugin) does not state that it's a V3 feature. I did a bunch of tests today and found that it's being ignored. You can set the config to complete garbage values and it was ignored. I also found that calls to get a token skip the auth drivers and talk right to the identity ones.

 <mfisch> morganfainberg: perhaps you can comment on a mystery, when I use password auth and request a token, is it supposed to go through the auth modules?
 <morganfainberg> mfisch, v2.0 or v3?
 <morganfainberg> mfisch, v3 is where the auth plugins/modules are used vs. the logic in the token auth controller
 <mfisch> morganfainberg: v2
 <mfisch> morganfainberg: I did see the token driver just calling right to the identity driver
 <mfisch> morganfainberg: ugh, so whats the point of an auth module in v2?
 <morganfainberg> mfisch, https://github.com/openstack/keystone/blob/master/keystone/token/controllers.py#L60
 <morganfainberg> mfisch, this is one of the benefits of using V3 (yes, I know, not supported everywhere yet)
 <mfisch> morganfainberg: yeah, thats the code I was looking at earlier, authenticate_local calls direct to ident
 <morganfainberg> mfisch, yep
 <morganfainberg> mfisch, v2.0 doesn't have the auth plugin mechanisms
 <morganfainberg> mfisch, it wasn't really designed with that in mind.
 <mfisch> morganfainberg: so the docs for it are really designed for v3
 <morganfainberg> mfisch, if we weren't clear on the auth plugins being a v3 thing we should get the docs updated
 <morganfainberg> mfisch, but yes, v3 is where auth plugin logic is used
 <mfisch> morganfainberg: I dont see it called out here: http://docs.openstack.org/developer/keystone/configuration.html#how-to-implement-an-authentication-plugin
 <morganfainberg> mfisch, yep, don't see it either. file a bug on this if you don't mind (feel free to fix it too if you're so inclined)
 <morganfainberg> mfisch, good catch.
 <mfisch> not sure if happy to be right or sad that it doesn't work
 <morganfainberg> mfisch, well, help us get everyone moved to v3 :) then it'll work like you expect!
 <morganfainberg> mfisch (shameless plug for help to get OpenStack on keystone V3)
 <mfisch> I'm on board

Changed in keystone:
status: New → Triaged
importance: Undecided → Low
tags: added: low-hanging-fruit
Dolph Mathews (dolph)
tags: added: documentation
Changed in keystone:
assignee: nobody → Kevin Kirkpatrick (kevkirkpatrick)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/91596

Changed in keystone:
status: Triaged → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/91631

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/91631
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=53d64599781dab2d7d8d41d2865ee3284c005eb8
Submitter: Jenkins
Branch: master

commit 53d64599781dab2d7d8d41d2865ee3284c005eb8
Author: Kevin Kirkpatrick <email address hidden>
Date: Thu May 1 10:56:18 2014 -0700

    Add note for v3 API clients using auth plugin docs

    Change-Id: I3d07c3f27ac38f9ead0481271460b3b3633b8c1d
    Closes-Bug: #1311324

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Steve Martinelli (<email address hidden>) on branch: master
Review: https://review.openstack.org/91596
Reason: https://review.openstack.org/#/c/91631/ contains this change, and is merged.

Thierry Carrez (ttx)
Changed in keystone:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.