ProcessLauncher needs a stop method

[Carl Baldwin]

ProcessLauncher has no stop or kill method. Neutron -- for one -- may call this method and get an AttributeError when it does.

[Ben Nemec (bnemec)]

That's...odd. How did Neutron end up calling a method that doesn't exist? Did we remove it at some point?

[Carl Baldwin (carl-baldwin)]

It is odd. I think the code path was never tested and is obviously not exercised in our tests. We can't add tests which exercise it until it is implemented. :)

[ChangBo Guo(gcb) (glongwave)]

Can you add more details about the code path ? A source code link is appreciated.

[Carl Baldwin (carl-baldwin)]

Here is the neutron path that would call it: https://review.openstack.org/#/c/72564/. Before, this code was trying to just set .running to False hoping that would stop the sub-processes. I don't think that is correct.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/89686
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=5f12bba4267b3a34b8d9db99928c998ae197fc52
Submitter: Jenkins
Branch: master

commit 5f12bba4267b3a34b8d9db99928c998ae197fc52
Author: Carl Baldwin <email address hidden>
Date: Tue Apr 22 19:55:09 2014 +0000

    Implement stop method in ProcessLauncher

    This implements a stop call in ProcessLauncher which will stop respawn
    loops and terminate children.

    Change-Id: I13d03b2007f1b53387945b74f70f676734ad8167
    Closes-Bug: #1311306