timezone incorrectly modified when editing/creating google calendar event
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Calendar App |
Fix Released
|
High
|
Unassigned | ||
Ubuntu UI Toolkit |
Fix Released
|
Critical
|
Renato Araujo Oliveira Filho | ||
qtorganizer5-eds |
Fix Released
|
High
|
Renato Araujo Oliveira Filho | ||
qtorganizer5-eds (Ubuntu) |
Confirmed
|
High
|
Unassigned |
Bug Description
We are not preserving the time zone of a calendar event after editing it.
- Create an event in Google Calendar (using browser calendar.
- Ensure your timezone on device is set to your correct timezone (UTC -4 in my case) by accessing system-settings
- Import Calendar from Google account (by setting up online account for Google)
- Verify the "Test" event shows up correctly in Calendar app at 12pm
- Now edit the event and change the description to "Test, 123" and save the event.
- After the sync runs (wait one or two minutes), open your browser and reload your google calendar
Expected result:
- Event should be called "Test, 123" and still at 12pm local time
Actual results:
- Event is correctly updated to show "Test, 123" but time has shifted to 3pm local time
We should not be modifying the timezone when editing the event
Related branches
- Charles Kerr (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Nekhelesh Ramananthan (community): Approve (testing on mako n4 image r79)
-
Diff: 1160 lines (+367/-286)12 files modifiedorganizer/qorganizer-eds-engine.cpp (+48/-23)
organizer/qorganizer-eds-savecollectionrequestdata.cpp (+0/-2)
organizer/qorganizer-eds-viewwatcher.cpp (+0/-2)
tests/unittest/CMakeLists.txt (+0/-28)
tests/unittest/cancel-operation-test.cpp (+2/-8)
tests/unittest/collections-test.cpp (+144/-125)
tests/unittest/eds-base-test.cpp (+8/-26)
tests/unittest/eds-base-test.h (+5/-7)
tests/unittest/event-test.cpp (+107/-29)
tests/unittest/fetchitem-test.cpp (+3/-6)
tests/unittest/recurrence-test.cpp (+27/-26)
tests/unittest/run-eds-test.sh (+23/-4)
- PS Jenkins bot: Approve (continuous-integration)
- Nekhelesh Ramananthan (community): Approve (testing on mako n4 image r79)
- Zsombor Egri: Approve
-
Diff: 119 lines (+16/-18)1 file modifiedmodules/Ubuntu/Components/plugin/adapters/alarmsadapter_organizer.cpp (+16/-18)
Changed in ubuntu-calendar-app: | |
status: | New → Confirmed |
Changed in qtorganizer5-eds: | |
assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
importance: | Undecided → Medium |
summary: |
- timezone incorrectly modified when editing google calendar event + timezone incorrectly modified when editing/creating google calendar + event |
Changed in qtorganizer5-eds: | |
importance: | Medium → High |
Changed in qtorganizer5-eds (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
importance: | Undecided → Critical |
assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
tags: | added: rtm14 |
Changed in ubuntu-ui-toolkit: | |
status: | Confirmed → Fix Committed |
Changed in ubuntu-ui-toolkit: | |
milestone: | none → 10.24 |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
Changed in qtorganizer5-eds: | |
status: | Confirmed → Fix Released |
Changed in qtorganizer5-eds (Ubuntu): | |
status: | Confirmed → Fix Released |
Changed in ubuntu-calendar-app: | |
importance: | Undecided → High |
Changed in qtorganizer5-eds (Ubuntu): | |
status: | Fix Released → Confirmed |
Changed in ubuntu-calendar-app: | |
status: | New → Confirmed |
Changed in ubuntu-calendar-app: | |
status: | Confirmed → Fix Released |
Tried to add log to calendar and debug the issue, before and after editing event. Event timezone is same for QML event object.
Looks like EDS is not preserving time zone
Event Details: Sat May 24 15:00:00 2014 GMT+0900 -- Sat May 24 18:30:00 2014 GMT+0900
Edit events start up: Sat May 24 15:00:00 2014 GMT+0900 -- Sat May 24 18:30:00 2014 GMT+0900
before saving Edit: Sat May 24 15:00:00 2014 GMT+0900 -- Sat May 24 18:30:00 2014 GMT+0900
After saving Edit: Sat May 24 15:00:00 2014 GMT+0900 -- Sat May 24 18:30:00 2014 GMT+0900
Event Details: Sat May 24 15:00:00 2014 GMT+0900 -- Sat May 24 18:30:00 2014 GMT+0900