ip-lib : "ip neigh" command should use "replace" instead of "add"

Bug #1311002 reported by Mathieu Rohon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Mathieu Rohon

Bug Description

with l2-population and linuxbridge agent, we used to use "ip neigh" command to add arp responder entries :
this command has been generalized with this patch :
https://review.openstack.org/#/c/88442/3

but using "ip neigh add" leads to a bug when restoring a previous entry :
https://bugs.launchpad.net/neutron/+bug/1282662

we should use "ip neigh replace" instead of "ip neigh add'"

Changed in neutron:
assignee: nobody → Mathieu Rohon (mathieu-rohon)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89522

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → High
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/89522
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6ca8e28d3100b1860af5f36d7a0e59fc7b500c29
Submitter: Jenkins
Branch: master

commit 6ca8e28d3100b1860af5f36d7a0e59fc7b500c29
Author: mathieu-rohon <email address hidden>
Date: Tue Apr 22 11:44:35 2014 +0200

    ip-lib : use "ip neigh replace" instead of "ip neigh add"

    Closes bug #1311002

    Change-Id: Ie50bc0bff32b7f97ac317ccc2521bbea52d59ca3

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.