nova network floating IP has direct DB access

[Bob Ball]

nova-network with floating IPs is currently broken due to a direct DB access

2014-04-22 08:04:32.395 ESC[01;31mERROR oslo.messaging.rpc.dispatcher [ESC[01;36mreq-8fa8da3a-2e61-47e9-a6c6-68f598e979ad ESC[00;36mTestServerAdvancedOps-228418898
TestServerAdvancedOps-892915532ESC[01;31m] ESC[01;35mESC[01;31mException during message handling: nova-computeESC[00m
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 133, in _dispatch_and_reply
    incoming.message))
  File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 176, in _dispatch
    return self._do_dispatch(endpoint, method, ctxt, args)
  File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 122, in _do_dispatch
    result = getattr(endpoint, method)(ctxt, **new_args)
  File "/opt/stack/nova/nova/exception.py", line 88, in wrapped
    payload)
  File "/opt/stack/nova/nova/openstack/common/excutils.py", line 82, in __exit__
    six.reraise(self.type_, self.value, self.tb)
  File "/opt/stack/nova/nova/exception.py", line 71, in wrapped
    return f(self, context, *args, **kw)
  File "/opt/stack/nova/nova/compute/manager.py", line 276, in decorated_function
    pass
  File "/opt/stack/nova/nova/openstack/common/excutils.py", line 82, in __exit__
    six.reraise(self.type_, self.value, self.tb)
  File "/opt/stack/nova/nova/compute/manager.py", line 262, in decorated_function
    return function(self, context, *args, **kwargs)
  File "/opt/stack/nova/nova/compute/manager.py", line 329, in decorated_function
    function(self, context, *args, **kwargs)
  File "/opt/stack/nova/nova/compute/manager.py", line 250, in decorated_function
    migration.instance_uuid, exc_info=True)
  File "/opt/stack/nova/nova/openstack/common/excutils.py", line 82, in __exit__
    six.reraise(self.type_, self.value, self.tb)
  File "/opt/stack/nova/nova/compute/manager.py", line 237, in decorated_function
    return function(self, context, *args, **kwargs)
  File "/opt/stack/nova/nova/compute/manager.py", line 305, in decorated_function
    e, sys.exc_info())
  File "/opt/stack/nova/nova/openstack/common/excutils.py", line 82, in __exit__
    six.reraise(self.type_, self.value, self.tb)
  File "/opt/stack/nova/nova/compute/manager.py", line 292, in decorated_function
    return function(self, context, *args, **kwargs)
  File "/opt/stack/nova/nova/compute/manager.py", line 3472, in resize_instance
    migration_p)
  File "/opt/stack/nova/nova/network/api.py", line 45, in wrapped
    return func(self, context, *args, **kwargs)
  File "/opt/stack/nova/nova/network/api.py", line 492, in migrate_instance_start
    self._get_floating_ip_addresses(context, instance)
  File "/opt/stack/nova/nova/network/api.py", line 474, in _get_floating_ip_addresses
    instance['uuid'])
  File "/opt/stack/nova/nova/db/api.py", line 700, in instance_floating_address_get_all
    return IMPL.instance_floating_address_get_all(context, instance_uuid)
  File "/opt/stack/nova/nova/cmd/compute.py", line 52, in __call__
    raise exception.DBNotAllowed('nova-compute')
DBNotAllowed: nova-compute

[Bob Ball (bob-ball)]

This bug was introduced by commit https://review.openstack.org/#/c/87019/

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/89580
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=625e48f82b5c7f1d55641b4207afd85b0b798cc2
Submitter: Jenkins
Branch: master

commit 625e48f82b5c7f1d55641b4207afd85b0b798cc2
Author: Dan Smith <email address hidden>
Date: Tue Apr 22 06:59:43 2014 -0700

    Fix migrate_instance_*() using DB for floating addresses

    This fixes the network api's migrate_instance_start() and
    migrate_instance_finish() methods that are still hitting the database
    directly for an oddball call to get a list of floating addresses.

    Change-Id: Ia310e31d31aaf5c979e41c64af8223202a18e03a
    Closes-bug: #1310966