Change start/stop times

[Paul Loschak]

This is a wishlist item. It would be helpful if I could go into the properties (similar to in itunes) and change the time in a song that I want the song to start or stop at. For example, some songs have long obnoxious intros, and I would prefer if the playback simply started at 0:30.00 instead of 0:00.00. Similar request for the endings of songs.

[Dustin Spicuzza (dustin-virtualroadside)]

Implemented in r4492. Try it out and let me know if it works.

Currently, the editing for the start/stop offsets are just integer seconds in the properties that aren't validated. I'll put something better in at a later date.

[Rocco Aliberti (eri.trabiccolo)]

Stop doesn't really work. It stops almost one second after the start.
Debug:
start = 15
stop = 30

print of some values in ._base._monitor_for_stop:
get_position() => 15673446712
stop_offset*1000 => 30000

You should use get_time() instead of get_position() and then just stop_offset instead of stop_offset*1000.

Patch against r4492 attached

[Dustin Spicuzza (dustin-virtualroadside)]

Ah, looks like the documentation for get_position was wrong. It just so happened that the file I was testing with was with a one second stop condition… oops.

I've updated the documentation and the code, available as of r4493.

[Rocco Aliberti (eri.trabiccolo)]

Eheh sorry, didn't read the documentation. Once I've found that nanoseconds issue I went into get_position and seen right below that the get_time method which already did what "we" wanted, sloppy me :D