Trove is not monkey patching eventlet early enough

[Tim Simpson]

Trove API isn't calling the eventlet monkey patch routines early enough, leading it to use certain packages which can't be safely mixed with eventlet greenthreads.

To see, open up trove/flavors/views.py and replace the FlavorsView.data method with this:

def data(self):
      import thread
      from eventlet.patcher import is_monkey_patched
      return {"Thread is using eventlet": "%s" % str(is_monkey_patched(thread)) }

Next, start up Trove API and list the flavors. What you'll see come back is:

{"Thread is using eventlet": "False"}

This is dangerous for a number of reasons.

Now, if trove/cmd/api.py is fixed by adding the monkey patch logic to the top the flavors view will show the eventlet version of the thread module is being used.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/89425

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/89425
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=ac572a8ae01784c0b9442320bf131938de90b102
Submitter: Jenkins
Branch: master

commit ac572a8ae01784c0b9442320bf131938de90b102
Author: Tim Simpson <email address hidden>
Date: Thu Apr 24 14:42:39 2014 -0500

    Make sure eventlet starts correctly

    This commit prevents a bug where eventlet was not being monkey patched
    correctly. It also puts some code common to most of the scripts into
    a common module to prevent some of the confusion surrounding
    this and other initialization issues.

    Closes-Bug: #1310785

    Change-Id: I433dde896d7384e577e60ac3dd795a9c5c97d689