Loadbalancer in autoscalinggroup delete members incorrectly

[Zhang Yang]

some members in loadbalancer couldn't be deleted, because when deleting a loadbalancer, the loadbalancer resource want to get all members from tmplate, which is incorrect in autoscaling.
the same bug is https://bugs.launchpad.net/heat/+bug/1248218, but the patch just fix the bug in update.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/89359

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/104061

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/128729

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/128729
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3f33130b89b96c6fcc1dace12498f691413e4713
Submitter: Jenkins
Branch: master

commit 3f33130b89b96c6fcc1dace12498f691413e4713
Author: Zane Bitter <email address hidden>
Date: Wed Oct 15 12:08:13 2014 -0400

    Ensure all Neutron LoadBalancer members are deleted

    Previously we only deleted the ones listed in the template, even though
    members can be added by autoscaling that don't appear in the template. In
    theory this is OK if we're deleting the autoscaling group too, and since
    it's not possible to update the LoadBalancer property on an autoscaling
    group I can't find a way to actually trigger any bug (hence no new test).
    However, it's much safer to ensure we delete all of the remaining members
    when we delete the LoadBalancer resource.

    Change-Id: I6f1c02ae408e9169a23ae32e7fce5ea0d2239add
    Closes-Bug: #1310602

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/151179

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151179
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=42b032f8bd3680f3bdfff78fe6152d6243549d54
Submitter: Jenkins
Branch: stable/juno

commit 42b032f8bd3680f3bdfff78fe6152d6243549d54
Author: Zane Bitter <email address hidden>
Date: Wed Oct 15 12:08:13 2014 -0400

    Ensure all Neutron LoadBalancer members are deleted

    Previously we only deleted the ones listed in the template, even though
    members can be added by autoscaling that don't appear in the template. In
    theory this is OK if we're deleting the autoscaling group too, and since
    it's not possible to update the LoadBalancer property on an autoscaling
    group I can't find a way to actually trigger any bug (hence no new test).
    However, it's much safer to ensure we delete all of the remaining members
    when we delete the LoadBalancer resource.

    Change-Id: I6f1c02ae408e9169a23ae32e7fce5ea0d2239add
    Closes-Bug: #1310602
    (cherry picked from commit 3f33130b89b96c6fcc1dace12498f691413e4713)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Angus Salkeld (<email address hidden>) on branch: master
Review: https://review.openstack.org/89359
Reason: adandoning old reviews, feel free to repost this if you want to get it merged.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Qiming Teng (<email address hidden>) on branch: master
Review: https://review.openstack.org/104061
Reason: no activity over 18 months.