restarting cinder-volume doesn't help volume and snapshot which status is creating

[haruka tanizawa]

When restart cinder-volume process, this should change volume
and snapshot status to valid status.

How to reproduce?
  1. Request create volume API.
  2. Unfortunately, cinder-volume process down, after the request.
  3. Remain creating status volume.
  4. With restarting of cinder-volume doesn't move this status forward.

What is the expected result?
  Restarting cinder-volume process make this halfway volume to 'error' status.
  (None -> creating -> error)

Others:
  This report is also same to snapshot.
  I know that I can delete this 'creating' volume with force-delete command.
  However, consistent with nova, from point of restarting process,
  transition to error status is needed, I think.

[haruka tanizawa (h-tanizawa)]

Should I separate this bug into volume and snapshot in this case??

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/90042

[OpenStack Infra (hudson-openstack)]

Change abandoned by Duncan Thomas (<email address hidden>) on branch: master
Review: https://review.openstack.org/90042
Reason: Abandoning change: No update for more than 14 days

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/149188

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149188
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e71006c49a280d53146fdbdfef9ce307d0a1d0de
Submitter: Jenkins
Branch: master

commit e71006c49a280d53146fdbdfef9ce307d0a1d0de
Author: Yasuaki Nagata <email address hidden>
Date: Thu Jan 22 17:45:08 2015 +0900

    Change volume and snapshot stuck creating to error

    Service of volume goes down after the status of
    the volume is turned 'creating', volume to remain with
    the status of the 'creating'.

    Status of the volume is still 'creating' even if
    volume service is restarted, it is impossible for user
    to remove it without force-delete.

    With this patch, in order to keep consistence with Nova,
    volume state 'creating' should be shifted to the 'error' properly.

    Closes-Bug: #1310526
    Co-Authored-By: Ivan Kolodyazhny <email address hidden>
    Change-Id: I89ef201f25b739cc443cb2920de2bd6ce89d97e1