OpenStack Compute (nova)

_heal_instance_info_cache should info info_cache as an expected_attrs

Bug #1309239 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Aaron Rosen
OpenStack Compute (nova) 2014.2 "juno"
Havana
Fix Released
Undecided
Unassigned
OpenStack Compute (nova) 2013.2.4
Icehouse
Fix Released
Medium
Aaron Rosen
OpenStack Compute (nova) 2014.1.1

Bug Description

The _heal_instance_info cache() is used to heal the cache access instance['info_cache'] so we should always load the info_cache so we can avoid the extra query to get it when accessed.

Aaron Rosen (arosen)
Changed in nova:
assignee: nobody → Aaron Rosen (arosen)
tags: added: havana-backport-potential icehouse-backport-potential
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88458

Changed in nova:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/88458
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5aa29b6b0a34d603e882a80cdc8e936f983b1892
Submitter: Jenkins
Branch: master

commit 5aa29b6b0a34d603e882a80cdc8e936f983b1892
Author: Aaron Rosen <email address hidden>
Date: Thu Apr 17 15:44:59 2014 -0700

    Remove unnecessary call to fetch info_cache

    The _heal_instance_info cache() always accesses instance['info_cache']
    therefore we should always load the info_cache so we can avoid the extra
    query to fetch it.

    Change-Id: I3c2e005b98abf2a80276562cc05e88ba5ff199bc
    Closes-bug: #1309239

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to nova (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/89652

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (stable/icehouse)

Reviewed: https://review.openstack.org/89652
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f1fdb3c033f691b1b2cf2fe57860d08102984cf4
Submitter: Jenkins
Branch: stable/icehouse

commit f1fdb3c033f691b1b2cf2fe57860d08102984cf4
Author: Aaron Rosen <email address hidden>
Date: Thu Apr 17 15:44:59 2014 -0700

    Remove unnecessary call to fetch info_cache

    The _heal_instance_info cache() always accesses instance['info_cache']
    therefore we should always load the info_cache so we can avoid the extra
    query to fetch it.

    Change-Id: I3c2e005b98abf2a80276562cc05e88ba5ff199bc
    Closes-bug: #1309239
    (cherry picked from commit 5aa29b6b0a34d603e882a80cdc8e936f983b1892)

tags: added: in-stable-icehouse
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/95631

Alan Pevec (apevec)
tags: removed: icehouse-backport-potential in-stable-icehouse
Alan Pevec (apevec)
Changed in nova:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/havana)

Reviewed: https://review.openstack.org/95631
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b0b523b4afff8f5a59aca23ccd3904eb4e29bf42
Submitter: Jenkins
Branch: stable/havana

commit b0b523b4afff8f5a59aca23ccd3904eb4e29bf42
Author: Aaron Rosen <email address hidden>
Date: Thu Apr 17 15:44:59 2014 -0700

    Remove unnecessary call to fetch info_cache

    The _heal_instance_info cache() always accesses instance['info_cache']
    therefore we should always load the info_cache so we can avoid the extra
    query to fetch it.

    Closes-bug: #1309239

    Conflicts:
     nova/compute/manager.py

    (cherry picked from commit 5aa29b6b0a34d603e882a80cdc8e936f983b1892)

    Change-Id: I3c2e005b98abf2a80276562cc05e88ba5ff199bc

tags: added: in-stable-havana
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.