NetworkCommandsTestCase unit test failing

[Mohammed Naser]

Change-Id I663bd06eb50872f16fc9889dde917277739fefce introduced a race condition where if another test doesn't properly reset the _IS_NEUTRON flag, it will fail because it will think that it is using Neutron and error out.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/88324

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/88324
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1722378c85dbc9dc2506a2f8a84fef7a27254f57
Submitter: Jenkins
Branch: master

commit 1722378c85dbc9dc2506a2f8a84fef7a27254f57
Author: Mohammed Naser <email address hidden>
Date: Thu Apr 17 21:01:10 2014 +0000

    Remove utils.reset_is_neutron() to avoid races

    If a unit test does not call utils.reset_is_neutron() when
    it is complete, it may introduce a race condition because
    the utils.is_neutron() value is cached to the old result.

    This patch removes the utils.reset_is_neutron() and instead
    makes sure that we never have a cached value for it. It
    also refactors _is_neutron out of vmwareapi.VMOps because
    it cache the result unnecessarily.

    Change-Id: I2440e308b00979b31c750513d14608808a295c33
    Closes-Bug: #1309043