Taskmanager writes guestagent conf to wrong place

[Greg Lucas]

The guest images produced by kick-start are putting the trove-guestagent.conf in /etc/trove/trove-guestagent.conf.

However, the task manager writes to /etc/trove-guestagent.conf during create. To avoid having passwords etc hard-coded on the guest images, the default behavior should be that the task manager pushes the guestagent conf file from the controller.

Per hub_cap's comments here: https://review.openstack.org/#/c/41300/2/trove/common/cfg.py : devstack/trove-integration should follow this approach, so the guest images should put/read the conf file from the same location the task manager uses.

[Greg Lucas (glucas-q)]

Arguably, the task manager should be writing to '/etc/trove/trove-guestagent.conf' instead.

Either way, we should be consistent between what the task manager does during create and how trove-integration sets up guest images.

[Nikhil Manchanda (slicknik)]

I agree with the latter comment.

All of trove's config should be under /etc/trove, so it's a fair cop to fix the taskmanager to actually write the conf to /etc/trove/trove-guestagent.conf/.

Thanks!

[Greg Lucas (glucas-q)]

Based on previous comments, changing this from a trove-integration bug to a trove bug -- we'll change where the task manager pushed the conf rather than where the guest reads it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/100381

[Greg Lucas (glucas-q)]

Question on this:

Shouldn't the guest_info file also getting written in the trove dir, i.e. /etc/trove/guest_info?

I haven't made this change in the patch set yet (it will require changing the upstart script in trove-integration as well) but makes sense to me.

[Vipul Sabhaya (vipuls)]

Greg +1, If we are making this change for trove-guestagent.conf, i would be in favor of moving guest_info to the same directory.

[Nikhil Manchanda (slicknik)]

Issue is not release critical to hold juno-rc1 for. Moving to kilo-1.

[Amrith Kumar (amrith)]

Updating importance to "Wishlist" (bugscrub, 2014-10-23)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/100381
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=a4e054e3ac68426b71a55dfedc4385966b0ef623
Submitter: Jenkins
Branch: master

commit a4e054e3ac68426b71a55dfedc4385966b0ef623
Author: Greg Lucas <email address hidden>
Date: Wed Oct 8 16:26:45 2014 +0300

    Inject guest conf files to configurable location

    Introduce a configuration option for a directory on the guest where the
    taskmanager should inject configuration files.

    During instance creation inject the guest_info and trove-guestagent
    conf files to the 'injected_config_location'. The default location is
    /etc/trove/conf.d.

    Also:
     - Change the default value for 'guest_config' to remove the risk of
       overwriting a guest image's conf file with the sample.
     - Add trove-guestagent.conf injection to heat template.
     - Add new 'guest_info' option that defaults to "guest_info.conf".

    Depends-On: I1dffd373da722af55bdea41fead8456bb60c82b2

    Co-Authored-By: Denis Makogon <email address hidden>
    Co-Authored-By: Duk Loi <email address hidden>

    DocImpact: This change introduces a new option with a default that
    affects existing guest images. The guestagent init script for any
    existing guest image will need to be modified to read the conf
    files from /etc/trove/conf.d. For backwards compatibility set the
    injected_config_location to /etc/trove and guest_info to
    /etc/guest_info.

    Closes-Bug: 1309030
    Change-Id: I1057f4a1b6232332ed4b520dbc7b3bbb04145f73