Traling commas in JS files able to break Horizon on old web browsers.
Bug #1308952 reported by
Robert Mizielski
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
High
|
Robert Mizielski |
Bug Description
In some JS files, there are trailing commas able to break Horizon on old web browsers.
Example (in horizon/
domain: function($super) {
var ret = $super();
// If y axis wants to have static range, not based on data
if (this.yMin !== undefined && this.yMax !== undefined){
ret.y = [this.yMin, this.yMax];
}
return ret;
}, <-- can cause an error " Expected identifier, string or number".
});
Changed in horizon: | |
assignee: | nobody → Robert Mizielski (miziel-r) |
summary: |
- Unnecessary commas in JS files able to break Horizon on old web - browsers. + Traling commas in JS files able to break Horizon on old web browsers. |
description: | updated |
Changed in horizon: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: low-hanging-fruit |
tags: | added: icehouse-backport-potential |
Changed in horizon: | |
milestone: | none → juno-1 |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | juno-1 → 2014.2 |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/88265
Review: https:/