Traling commas in JS files able to break Horizon on old web browsers.

Bug #1308952 reported by Robert Mizielski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Robert Mizielski

Bug Description

In some JS files, there are trailing commas able to break Horizon on old web browsers.

Example (in horizon/static/horizon/js/horizon.d3linechart.js, line 187):

  domain: function($super) {
    var ret = $super();
    // If y axis wants to have static range, not based on data
    if (this.yMin !== undefined && this.yMax !== undefined){
      ret.y = [this.yMin, this.yMax];
    }
    return ret;
  }, <-- can cause an error " Expected identifier, string or number".
});

Changed in horizon:
assignee: nobody → Robert Mizielski (miziel-r)
summary: - Unnecessary commas in JS files able to break Horizon on old web
- browsers.
+ Traling commas in JS files able to break Horizon on old web browsers.
description: updated
Changed in horizon:
status: New → Triaged
importance: Undecided → High
tags: added: low-hanging-fruit
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88265

Changed in horizon:
status: Triaged → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/88265
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=445d2648360c8aced856101bfda6ca58a7135fe4
Submitter: Jenkins
Branch: master

commit 445d2648360c8aced856101bfda6ca58a7135fe4
Author: Robert Mizielski <email address hidden>
Date: Thu Apr 17 14:09:50 2014 +0200

    Remove trailing commas in JS files.

    Change-Id: I43b6c8cebc3bd265199fd163550520cf76d172ef
    Closes-bug: #1308952

Changed in horizon:
status: In Progress → Fix Committed
Julie Pichon (jpichon)
tags: added: icehouse-backport-potential
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.