In Waveform display, make it possible to move the "currently playing this position"-marker

Bug #1308643 reported by Dario Ernst
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
Unassigned

Bug Description

The current waveform display features a bar in the center that tells the user "this is the part thats currently played back". Everything left of it has already been played, right of it is whats going to be played rather soon. Some users may prefer to have a larger "look-a-head" and care less for what happened in the past. A solution to this might be to make the "currently playing" marker relocatable, so that users could move it to the very left edge, at 25%, at 50% (currently) or maybe even more forward.

Tags: waveform
Owen Williams (ywwg)
Changed in mixxx:
importance: Undecided → Low
importance: Low → Wishlist
Changed in mixxx:
status: New → Confirmed
Revision history for this message
jus (jus) wrote :

In some other soft the position marker moves from left to right over the fixed visible part of the waveform . Once the marker reaches the end of the waveform clip, the waveform flips over to the next part and so does the position marker.

tags: added: waveform
Revision history for this message
Dario Ernst (n-launchpad-nebuk-de) wrote :

I'd say thats an additional way of displaying the waveform. So we can maybe now make the request more generic, and say we have 3 waveform displays we want to be able to configure:
- Bar in the Middle
- Bar adjustable
- Cyclic moving bar with constant but changing underlying waveform

Any more ideas while we're at it, thinking up more work for our poor devs? :)

Thanks and Best Regards
-Dario Ernst

Revision history for this message
Daniel Schürmann (daschuer) wrote :

It this really a desired version?
- Cyclic moving bar with constant but changing underlying waveform

Of cause it is a CPU saver, but it there a use case for this?

Revision history for this message
Dario Ernst (n-launchpad-nebuk-de) wrote :

I'd say there is only a usecase for this because other software has it. People switching from proprietary legacy software to mixxx would/could find themselves more at home that way?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

An other aspect it the play position alignment when switching spinies.

Revision history for this message
ronso0 (ronso0) wrote :

For FlatNite someone was requesting to shift the PlayPosition marker and I found a workaround on skin level until this is implemented.
Working on 2.1 alpha-pre

Add the snippet below to style.qss and replace 'WaveformContainer' with the actual <ObjectName> of well... the waveforms' container.
Adjust '-123' so it matches your needs: negative values shift marker to the left. If it should shift to the right, probably "margin-right: -AAApx;" should work.

#WaveformContainer {
   margin-left: -123px;
}

Revision history for this message
NT Music (ntmusic-deactivatedaccount) wrote :

Moving just the marker is quite easy even in the code (screenshot attached), moving the actual play position (especially using an arbitrary value) looks quite harder.

Revision history for this message
NT Music (ntmusic-deactivatedaccount) wrote :

After few more tries found how to move the play position along with the marker. The only thing left is the empty portion of the track (the triangles) is still rendered to the center of the widget, but this should be easy to fix. I suggest to implement 1/4 and 1/2 positions first, not sure if it worth to have more values than that (especially values higher than 1/2).

Changed in mixxx:
assignee: nobody → NT Music (ntmusic)
Revision history for this message
Be (be.ing) wrote :

The marker position is totally arbitrary. There is no need to impose artificial limits by only presenting a limited set of options. I think the preference option would be well suited to a slider. There is a finite 0-100% range and the user should be able to choose any value within that.

Revision history for this message
NT Music (ntmusic-deactivatedaccount) wrote :

I added a parameter to specify play marker position (range is between 0.0 < pos < 1.0, with 0.5 being the center (default) position).

Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
NT Music (ntmusic-deactivatedaccount) wrote :

PR #1520

Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
jus (jus) wrote :

Thanks for the PR, link for reference
https://github.com/mixxxdj/mixxx/pull/1520

In progress = Coding/Review in progress, not merged to target branch yet
Fix committed = Merged to target branch

Changed in mixxx:
status: Fix Committed → In Progress
milestone: none → 2.2.0
Revision history for this message
Be (be.ing) wrote :
Be (be.ing)
Changed in mixxx:
status: In Progress → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7436

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.