Mixxx

Preferences global apply button

Bug #1308552 reported by RJ Skerry-Ryan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
RJ Skerry-Ryan
Mixxx 2.0.0 "1.12.0"

Bug Description

Right now some preference pages have their own apply and reset buttons. We should move these to the button bar at the bottom.

* Consistent behavior across pages.
* Saves vertical space

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I'm kind of at a breaking point with the preferences code so I'm working on this right now.

tags: added: preferences
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Bug #1272394 is related though I see that as making the behavior of the reset buttons consistent. This bug is about putting them in the chrome wrapping each preference page.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Open question: should a global apply button apply all the preference pages or just the active one? The reset to defaults button should only affect the current page.

The OK button applies all the pages currently, so maybe the global apply button should.

tags: added: polish
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I added a reset button to the preferences button bar at the bottom.
https://github.com/mixxxdj/mixxx/commit/5f8670a7ddcca2bf82f89cb2e64b6116ee0ff02d

summary: - Preferences global apply and reset to defaults buttons
+ Preferences global apply button
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Added an apply button:
https://github.com/mixxxdj/mixxx/commit/263d1f5d343fbfdd1c4704b803673bdefdb755b1
and removed the individual ones.

It only applies the current page though. Should it apply all pages?

Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
milestone: none → 1.12.0
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7432

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.