Murano

[dashboard] Incorrect processing of inability to delete metadata

Bug #1308519 reported by Anastasia Kuznetsova on 2014-04-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Murano	Fix Released	Low	Ryan Peters	Murano 0.5

Bug Description

Steps to reproduce:
1. Log in WebUI
2. Navigate to Murano>Manage>Images
3. Select some public metadata (that current user can't modify, like non-admin user (member))
4. Try to delete it

Observed result:
Two contradictory messages are in WebUI (look at screenshot)

See original description

Tags:

Revision history for this message

Anastasia Kuznetsova (akuznetsova) wrote on 2014-04-16:

Screenshot from 2014-04-16 16:42:57.png Edit (60.0 KiB, image/png)

description:

updated

Serg Melikyan (smelikyan) on 2014-04-17

Changed in murano:
milestone:	none → 0.5
status:	New → Confirmed
importance:	Undecided → Low

Timur Sufiev (tsufiev-x) on 2014-04-17

tags:

added: low-hanging-fruit

Ryan Peters (rjpeter2) on 2014-04-21

Changed in murano:
assignee:	nobody → Ryan Peters (rjpeter2)

Revision history for this message

Ekaterina Chernova (efedorova) wrote on 2014-04-23:

Please wait until https://review.openstack.org/#/c/89565/ will be merged. Image panel will be hide if user is not admin and this error should not appear anymore

Revision history for this message

Openstack Gerrit (openstack-gerrit) wrote on 2014-04-23: Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89876

Changed in murano:
status:	Confirmed → In Progress

Revision history for this message

Openstack Gerrit (openstack-gerrit) wrote on 2014-04-24: Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/89876
Committed: https://git.openstack.org/cgit/stackforge/murano-dashboard/commit/?id=3a487a83676f4e668af1edc9dd6256ce562fb840
Submitter: Jenkins
Branch: master

commit 3a487a83676f4e668af1edc9dd6256ce562fb840
Author: Ryan Peters <email address hidden>
Date: Wed Apr 23 10:18:12 2014 -0500

Fixes incorrect processing of deleting metadata

    When a non-admin tries to delete metadata from a marked image,
    they are correctly getting an error message, however they are
    also getting a success message when they shouldn't. This code
    fixes the incorrect success message.

Closes-Bug: #1308519
Change-Id: I909551365b4a92675d26c1da754e586685a4aa32