Encoding mismatch

[Tim Waugh]

The "commafy" function has an encoding mismatch. locale.format() uses LC_NUMERIC, but locale.getpreferredencoding() may not.

Patch attached.

Original report:
  https://bugzilla.redhat.com/show_bug.cgi?id=984167#c9

[Tim Waugh (twaugh)]

Sorry, first patch had a typo.

[Suma Byrappa (suma-byrappa)]

Hi Tim,

Thanks for providing the patch. However this part of the code is already modified, which will be available publicly in one of the upcoming releases of HPLIP.

Thanks,
Suma

[Tim Waugh (twaugh)]

I can't see which change you referred to.

Anyway, attaching the latest patch. If you could attach the patch you're thinking of so we can compare, that would be great.

[Suma Byrappa (suma-byrappa)]

Hi Tim,

The change I referred to has not gone out yet. It is likely to be available in the next release.

Regards,
Suma

[Tim Waugh (twaugh)]

Thanks. Want to attach it here, or comment on how it differs from my patch, or comment on my patch?

[Suma Byrappa (suma-byrappa)]

Hi Tim,

I tried to get the patch, but there is a problem. The change I mentioned was done as part of a feature implementation. The nature of changes is such that giving a patch only for the commafy() function or the file containing it (utils.py) isn't going to help. So, we request you to wait for a little while more.

Regards,
Suma