Using deleted image as marker does not return bad request with v2 registry

Bug #1308404 reported by Erno Kuvaja
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Unassigned

Bug Description

$ ./run_tests.sh --subunit glance.tests.functional.v2.test_images.TestImages.test_images_container
Running `tools/with_venv.sh python -m glance.openstack.common.lockutils python setup.py testr --testr-args='--subunit --concurrency 1 --subunit glance.tests.functional.v2.test_images.TestImages.test_images_container'`
glance.tests.functional.v2.test_images.TestImages
    test_images_container FAIL

Slowest 1 tests took 12.71 secs:
glance.tests.functional.v2.test_images.TestImages
    test_images_container 12.71

======================================================================
FAIL: glance.tests.functional.v2.test_images.TestImages.test_images_container
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
  File "/home/ubuntu/glance/glance/tests/functional/v2/test_images.py", line 1649, in test_images_container
    self.assertEqual(400, response.status_code)
  File "/home/ubuntu/glance/.venv/local/lib/python2.7/site-packages/testtools/testcase.py", line 321, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/home/ubuntu/glance/.venv/local/lib/python2.7/site-packages/testtools/testcase.py", line 406, in assertThat
    raise mismatch_error
MismatchError: 400 != 200

1646 # Ensure bad request for using a deleted image as marker
1647 path = self._url('/v2/images?marker=%s' % images[0]['id'])
1648 response = requests.get(path, headers=self._headers())
1649 self.assertEqual(400, response.status_code)

Revision history for this message
Erno Kuvaja (jokke) wrote :

This test has been ran with change: https://review.openstack.org/#/c/87726/

Revision history for this message
Rajesh Tailor (rajesh-tailor) wrote :

IMO this bug is not reproducible with current master. I request you to mark it as closed.

Revision history for this message
Erno Kuvaja (jokke) wrote :

it indeed looks like this bug has been fixed on current master. Thanks Rajesh!

Changed in glance:
status: New → Fix Committed
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.