Properties have to have only different names

Bug #1308399 reported by Sergey Kraynev
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Triaged
Low
Unassigned
Pyyaml
New
Unknown

Bug Description

Currently you could define template with resources, which have same names.
However as result you will get only second definition of this resource.
I think that it's incorrect behavior and should be caught during validation.

As example try next template:

heat_template_version: 2013-05-23

resources:
  compute_instance:
    type: OS::Nova::Server
    properties:
        name: Hello1
        key_name : heat_key
        image : fedora-20.x86_64
        flavor: m1.small
  compute_instance:
    type: OS::Nova::Server
    properties:
        name: hello2
        key_name : heat_key
        image : fedora-20.x86_64
        flavor: m1.small

skr@devstack:~$ nova list
+--------------------------------------+--------+--------+------------+-------------+------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+--------+--------+------------+-------------+------------------+
| 58d389b0-bbe6-4be6-ae30-6e5e72bac5e8 | hello2 | ACTIVE | - | Running | private=10.0.0.5 |

Also same validation should be added for parameters (https://bugs.launchpad.net/heat/+bug/1308400) and outputs sections (https://bugs.launchpad.net/heat/+bug/1308401)

Changed in heat:
assignee: nobody → Sergey Kraynev (skraynev)
description: updated
summary: - Properties should have different names
+ Properties have to have only different names
Changed in heat:
status: New → Triaged
importance: Undecided → Low
Changed in pyyaml:
status: Unknown → New
Changed in heat:
assignee: Sergey Kraynev (skraynev) → jui chandwaskar (jui-136)
status: Triaged → In Progress
Revision history for this message
Sergey Kraynev (skraynev) wrote :

HI, jui chandwaskar. I tolerate, that somebody takes bug assigned on another person without any questions.... (but it is still roughly).

Another issues, that this can not be fixed normally without fix in pyyaml library (look bug above). So I don't see any reason, why you take it so fast.

Revision history for this message
jui chandwaskar (jui-chandwaskar) wrote :

Hi,

Thought of it from heat source.

Yes checked the above pyyaml library bug now, so will wait for the fix.

Changed in heat:
assignee: jui chandwaskar (jui-136) → nobody
status: In Progress → New
Angus Salkeld (asalkeld)
Changed in heat:
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.