Pagination limits code needs to be shared

Bug #1308285 reported by Vipul Sabhaya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Wishlist
Ishita Mandhan

Bug Description

Currently, there is code in extensions/mysql/models.py that determines the limit to pass down to the guest. Similar code exists in instances/models.py.

    limit = cls.DEFAULT_LIMIT if limit > cls.DEFAULT_LIMIT else limit

We should have a common place where this logic can exist to ensure that behavior remains consistent.

Changed in trove:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Amrith Kumar (amrith) wrote :

Updating importance to "Wishlist" (bugscrub, 2014-10-23)

Changed in trove:
importance: Medium → Wishlist
Changed in trove:
assignee: nobody → Ishita Mandhan (imandhan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235017

Changed in trove:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/235017
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=0746e70cb5e367d89980f4e1166458afed194fe1
Submitter: Jenkins
Branch: master

commit 0746e70cb5e367d89980f4e1166458afed194fe1
Author: Ishita Mandhan <email address hidden>
Date: Wed Oct 14 16:22:54 2015 -0700

    Pagination limit code refactor

    The logic to find the pagination limit is
    repeated several times and is not in one
    function. This patch creates a function that
    is called in various locations replacing
    repetitive code.

    Change-Id: I3eced6a4236e4189e57ea5a1589e8f0d411cc4e3
    Closes-Bug: #1308285

Changed in trove:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/trove 5.0.0.0b1

This issue was fixed in the openstack/trove 5.0.0.0b1 development milestone.

Changed in trove:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.