Reset state doesn't update migration status

[John Griffith]

In the case of a failed migration the volume's status and the migration status are both set to error state. We have the ability to use reset-state to get the volume back to a usable state, however the migration-status isn't updated which makes it impossible to do things like delete the volume or perhaps retry the migration.

We should have the reset-state command clean up outliers like this as well.

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/88083

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/88083
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=aabb0fa1f68974e2fa4828cde1462dc47c429655
Submitter: Jenkins
Branch: master

commit aabb0fa1f68974e2fa4828cde1462dc47c429655
Author: john-griffith <email address hidden>
Date: Wed Apr 16 15:03:18 2014 -0600

    Allow reset-state on attach and migration fields

    The reset-state API call only sets that main status
    column on the volume object. There's also a method
    to set attach status, however it turns out that due
    to the implementation of the status validation method
    in the parent class, this was impossible to use because
    it only checked and accepted "status" NOT "attach_status".

    This patch fixes that attach_status problem, it also implements
    the ability to update the migration status. A cinderclient change
    will be needed to expose these calls as well.

    DocImpact

    Change-Id: I59e1bb2522f033c944fa07acf4876ca71c8c3d3f
    Closes-Bug: #1308253

[Lingxian Kong (kong)]

Hi john:

I want to be a vonlunteer, working on cinderclient for this bug, to support the added ability for cinder volume status reset operation.

What I need to do is add cinderclient project, and assign to me, right?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/100427

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114917

[OpenStack Infra (hudson-openstack)]

Change abandoned by hzxiongwenwu (<email address hidden>) on branch: master
Review: https://review.openstack.org/114917

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lingxian Kong (<email address hidden>) on branch: master
Review: https://review.openstack.org/100427

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/128200

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/128200
Reason: This review is > 8 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Mitsuhiro Tanino (mitsuhiro-tanino)]

This bug for python-cinderclient is duplicate of https://bugs.launchpad.net/python-cinderclient/+bug/1309086
The fix was released.

Reviewed: https://review.openstack.org/164309
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=0f1cbc9e1f72c5ecd4c21b533bb03a8a9640f4c9
Submitter: Jenkins
Branch: master

commit 0f1cbc9e1f72c5ecd4c21b533bb03a8a9640f4c9
Author: Tomoki Sekiyama <email address hidden>
Date: Fri Mar 13 14:40:33 2015 -0400

    Implement reset-state for attach_status and migration_status

    Currently the reset-state command in the client only handles
    the main volume status column. This adds options to set
    attach_status and to reset migration_status.

    DocImpact: Add new options to cinder reset-state command
    Change-Id: Ifaa04c2f8a7ff21100f7c9c51df881313e8babea
    Closes-Bug: #1309086
Changed in python-cinderclient:
status: In Progress → Fix Committed