Ironic nova driver should be more efficient with ironic client calls

Bug #1308171 reported by David Shrewsbury
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Invalid
Low
Michael Davies
OpenStack Compute (nova)
Fix Released
Wishlist
Clif Houck

Bug Description

When the nova ironic driver makes ironic client calls, it currently gets a brand new client for each call. This can be done more efficiently by caching the client and re-authenticating as needed (e.g., when the auth token expires). With recent changes to the driver to cleanup the retry logic, this should be easier to do. [1][2] The driver class can contain a single IronicClientWrapper reference to use for the client calls, and the IronicClientWrapper object can handle caching and reauthenticating as needed.

[1] https://review.openstack.org/83105
[2] https://review.openstack.org/86993

Tags: ironic
Dmitry Tantsur (divius)
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
tags: added: low-hanging-fruit
Dmitry Tantsur (divius)
tags: added: driver
aeva black (tenbrae)
tags: added: nova-driver
removed: driver
Michael Davies (mrda)
Changed in ironic:
assignee: nobody → Michael Davies (mrda)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102695

Revision history for this message
Dmitry Tantsur (divius) wrote :

Ironic driver now leaves in Nova tree, so we can't fix this bug on Ironic side.

Changed in ironic:
status: In Progress → Invalid
Sean Dague (sdague)
Changed in nova:
status: New → Confirmed
importance: Undecided → Wishlist
aeva black (tenbrae)
tags: added: ironic
removed: low-hanging-fruit nova-driver
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Devananda van der Veen (<email address hidden>) on branch: master
Review: https://review.openstack.org/102695
Reason: The nova driver now lives in the Nova tree.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141188

Changed in nova:
assignee: nobody → Clif Houck (f-te-u)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/141188
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=806312a09933e6be0ee6f4f07dff01caf2345cdf
Submitter: Jenkins
Branch: master

commit 806312a09933e6be0ee6f4f07dff01caf2345cdf
Author: Clif Houck <email address hidden>
Date: Thu Dec 11 18:28:58 2014 -0600

    Cache ironic-client in ironic driver

    Cache the ironic-client in the IronicClientWrapper instead of constructing
    a new ironic-client for every relevant call in the ironic driver. This
    should reduce overhead for subsequent calls the driver makes to the
    ironic client.

    Change-Id: Ia1ffcd6027952db7f564cc189b2ac61f88b8c715
    Closes-Bug: #1308171

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.