Updating an in-progress stack should result in an HTTPConflict

Bug #1308109 reported by Jason Dunsmore
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Jason Dunsmore

Bug Description

Updating an in-progress stack should result in an HTTPConflict instead of an HTTPBadRequest. This error makes more sense from the user's perspective and is consistent with how other stack actions behave while the stack is in-progress (eg. stack-abandon).

Changed in heat:
importance: Undecided → Medium
milestone: none → juno-1
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89409

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/89409
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=34ec87cdd2fef28b7f06258da21445f49f2975ce
Submitter: Jenkins
Branch: master

commit 34ec87cdd2fef28b7f06258da21445f49f2975ce
Author: Jason Dunsmore <email address hidden>
Date: Tue Apr 15 16:20:43 2014 -0500

    Fix exceptions in update_stack

    Updating an in-progress stack is not supported by Heat. Previously, a
    NotSupported exception would be raised. This was not consistent with
    other actions, such as abandon stack. Instead, let StackLock.acquire
    raise an ActionInProgress exception. Suspended stacks will still result
    in a NotSupported exception being raised if an attempt is made to update
    them.

    Closes-Bug: #1308109
    Change-Id: Ic844b06cd654d7bd5d422bba81d1d8246a5d8dd0

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.