Return code incorrect when garbd is already running

[jmrenouard]

Context:
SysV init.d script: /etc/init.d/garb
Garbd is already running and started correctly.

Observed result:
service garb start
echo $?
0

Awaited result:
When garbd is already started, return code shouldn't return 0.
0 means success
If garbd is already running so trying to start garbd is expected to fail and return an non-zero return code.

Solution: return 3 instead of 0

--- garbd_origin 2014-04-15 16:48:20.115360380 +0200
+++ garb 2014-04-15 16:49:24.866360234 +0200
@@ -97,7 +97,7 @@

        if [ -r $PIDFILE ]; then
                log_failure "$prog is already running with PID $(cat ${PIDFILE})"
- return 0
+ return 3
        fi

        [ -x $prog ] || return 5

[jmrenouard (jmrenouard)]

This is maybe a galera project bug.

I will post it in the galera project instead.

[Raghavendra D Prabhu (raghavendra-prabhu)]

Yes, it indeed belongs to galera project.

[jmrenouard (jmrenouard)]

Hello,

Thanks for your feedback.

This bugs has been duplicated in galera project.

BR,
Jean-Marie RENOUARD
________________________________
Mobile : [phone]
Email : <email address hidden>
________________________________

On Wed, Apr 16, 2014 at 9:25 AM, Raghavendra D Prabhu <
<email address hidden>> wrote:

> Yes, it indeed belongs to galera project.
>
> ** Also affects: percona-xtradb-cluster
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1308100
>
> Title:
> Return code incorrect when garbd is already running
>
> Status in MySQL patches by Codership:
> New
> Status in Percona XtraDB Cluster - HA scalable solution for MySQL:
> New
>
> Bug description:
> Context:
> SysV init.d script: /etc/init.d/garb
> Garbd is already running and started correctly.
>
> Observed result:
> service garb start
> echo $?
> 0
>
> Awaited result:
> When garbd is already started, return code shouldn't return 0.
> 0 means success
> If garbd is already running so trying to start garbd is expected to fail
> and return an non-zero return code.
>
> Solution: return 3 instead of 0
>
> --- garbd_origin 2014-04-15 16:48:20.115360380 +0200
> +++ garb 2014-04-15 16:49:24.866360234 +0200
> @@ -97,7 +97,7 @@
>
> if [ -r $PIDFILE ]; then
> log_failure "$prog is already running with PID $(cat
> ${PIDFILE})"
> - return 0
> + return 3
> fi
>
> [ -x $prog ] || return 5
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/codership-mysql/+bug/1308100/+subscriptions
>