ML2 migration script does not check initial db version

Bug #1307720 reported by Maru Newby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Jakub Libosvar
Icehouse
Fix Released
Undecided
Unassigned

Bug Description

The ML2 migration script (https://github.com/openstack/neutron/blob/master/neutron/db/migration/migrate_to_ml2.py#L107) does not check that the target db's state is a valid target for migration. The intention was to add a check for the final icehouse alembic hash in the target db, but that hash was not available when the script was initially merged.

Maru Newby (maru)
Changed in neutron:
assignee: nobody → Mark McClain (markmcclain)
status: New → Confirmed
milestone: none → juno-1
tags: added: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/96201

Changed in neutron:
assignee: Mark McClain (markmcclain) → Jakub Libosvar (libosvar)
status: Confirmed → In Progress
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/96201
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=de10d7299ba3dce18b8e12a41830ec0e686df340
Submitter: Jenkins
Branch: master

commit de10d7299ba3dce18b8e12a41830ec0e686df340
Author: Jakub Libosvar <email address hidden>
Date: Wed May 28 18:39:47 2014 +0200

    Check DB scheme prior to migration to Ml2

    When using migration tool from LB/OVS plugin to Ml2, there is no
    guarantee current scheme is supported by migration tool. This patch
    checks version stored in DB by alembic and compares whether version
    is supported.

    Closes-bug: #1307720

    Change-Id: I4519a0e5a0f3027675958a68d1f9e0440b177229

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/99655

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/99655
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=71097a05755f1b1f7c4ed941545b12590165bfbd
Submitter: Jenkins
Branch: stable/icehouse

commit 71097a05755f1b1f7c4ed941545b12590165bfbd
Author: Jakub Libosvar <email address hidden>
Date: Wed May 28 18:39:47 2014 +0200

    Check DB scheme prior to migration to Ml2

    When using migration tool from LB/OVS plugin to Ml2, there is no
    guarantee current scheme is supported by migration tool. This patch
    checks version stored in DB by alembic and compares whether version
    is supported.

    Closes-bug: #1307720

    Change-Id: I4519a0e5a0f3027675958a68d1f9e0440b177229
    (cherry picked from commit de10d7299ba3dce18b8e12a41830ec0e686df340)

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.